Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake the use of gold linker configurable #7565
Merged
Conversation
Currently, ld.gold is always used for linking if found on the system. There are some cases however when one may want to opt out from using it. This patch adds the boolean field `rustc-with-gold` to the `[tools]` section of `.servobuild`, which if set false, disables the use of ld.gold.
|
solves #7564 |
|
Sounds reasonable. @bors-servo r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Sep 8, 2015
Make the use of gold linker configurable Currently, ld.gold is always used for linking if found on the system. There are some cases however when one may want to opt out from using it. This patch adds the boolean field `rustc-with-gold` to the `[tools]` section of `.servobuild`, which if set false, disables the use of ld.gold. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7565) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
akosthekiss commentedSep 8, 2015
Currently, ld.gold is always used for linking if found on the
system. There are some cases however when one may want to opt out
from using it. This patch adds the boolean field
rustc-with-goldto the
[tools]section of.servobuild, which if set false,disables the use of ld.gold.