Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OS-agnostic filesystem paths in Python #7568

Merged
merged 1 commit into from Sep 9, 2015
Merged

Use OS-agnostic filesystem paths in Python #7568

merged 1 commit into from Sep 9, 2015

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Sep 8, 2015

This will eventually need to be done for #1908

Review on Reviewable
@frewsxcv
Use OS-agnostic filesystem paths in Python
Loading status checks…
244af42 
This will eventually need to be done for #1908
@jdm
Copy link
Member

jdm commented Sep 8, 2015

@bors-servo: r+
Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Sep 8, 2015

📌 Commit 244af42 has been approved by jdm
@SimonSapin
Copy link
Member

SimonSapin commented Sep 8, 2015

I’m pretty sure that / works as a path separator on Windows.
@frewsxcv
Copy link
Member Author

frewsxcv commented Sep 8, 2015

I’m pretty sure that / works as a path separator on Windows.

That might be the case, but I think by default, most of the Python utilities like os.listdir(".") or os.walk(".") will use \ with paths on Windows, so probably better to stay consistent
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2015

⌛ Testing commit 244af42 with merge 8397219...
bors-servo pushed a commit that referenced this pull request Sep 9, 2015
bors-servo
Auto merge of #7568 - frewsxcv:os-agnostic-paths, r=jdm
Loading status checks…
8397219 
Use OS-agnostic filesystem paths in Python

This will eventually need to be done for #1908

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7568)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 244af42 into servo:master Sep 9, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 9, 2015

Are we upstream for mach_bootstrap.py?
@frewsxcv
Copy link
Member Author

frewsxcv commented Sep 9, 2015

If by that you mean, 'is there an associated upstream file for mach_bootstrap.py', in which case I assume the answer is 'no' but I might be wrong.
@metajack
Copy link
Contributor

metajack commented Sep 9, 2015

I originally modified the one from mozilla-central, but it would take a little bit of comparison to determine if these changes are relevant there.
@frewsxcv frewsxcv deleted the frewsxcv:os-agnostic-paths branch Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@frewsxcv @jdm @bors-servo @SimonSapin @Ms2ger @metajack @highfive
You can’t perform that action at this time.