Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add energy monitoring and characterization scripts #7581

Merged
merged 1 commit into from Sep 9, 2015

Conversation

@connorimes
Copy link
Contributor

connorimes commented Sep 9, 2015

Add the energy-profiling feature. Users can compile the proper (or their own) version of energymon libraries to capture power/energy data at runtime. The results are accessed through heartbeats.

Additionally, there are a couple of python scripts to enable heartbeats for profiler categories and process the results into some visualizations to help understand how time and energy is being spent in Servo.

Review on Reviewable

@highfive
Copy link

highfive commented Sep 9, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@connorimes
Copy link
Contributor Author

connorimes commented Sep 9, 2015

Documentation will follow.

Cargo.lock files do not get updated for ports. A bug in Cargo when using optional dependencies behind features? I specified a git rev for the energymon dependency in the toml file instead.

r? @larsbergstrom

@connorimes connorimes force-pushed the connorimes:power-profiling branch 2 times, most recently from 491eae5 to abe7ba3 Sep 9, 2015
@connorimes connorimes force-pushed the connorimes:power-profiling branch from abe7ba3 to 3c25f47 Sep 9, 2015
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Sep 9, 2015

Reviewed 11 of 14 files at r1.
Review status: 11 of 14 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.


tests/wpt/css-tests/css21_dev/html4/border-left-color-123.htm, line 0 [r1] (raw file):
Why is this deleted?


tests/wpt/css-tests/css21_dev/html4/border-left-color-124.htm, line 0 [r1] (raw file):
Why is this deleted?


tests/wpt/css-tests/css21_dev/html4/border-left-color-125.htm, line 0 [r1] (raw file):
Why is this deleted?


Comments from the review on Reviewable.io

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Sep 9, 2015

@bors-servo r+

(the questions above appear to be a reviewable.io UI bug)

@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2015

📌 Commit 3c25f47 has been approved by larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2015

Testing commit 3c25f47 with merge 7b6c341...

bors-servo pushed a commit that referenced this pull request Sep 9, 2015
Add energy monitoring and characterization scripts

Add the energy-profiling feature.  Users can compile the proper (or their own) version of energymon libraries to capture power/energy data at runtime.  The results are accessed through heartbeats.

Additionally, there are a couple of python scripts to enable heartbeats for profiler categories and process the results into some visualizations to help understand how time and energy is being spent in Servo.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7581)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2015

💔 Test failed - mac-rel-wpt

@jdm
Copy link
Member

jdm commented Sep 9, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2015

Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-ref-unit are reusable. Rebuilding only mac-rel-css, mac-rel-wpt...

@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2015

@bors-servo bors-servo merged commit 3c25f47 into servo:master Sep 9, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.