Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upimplement navigator.platform #7582
Conversation
|
FYI, one can use the if cfg!(all(any(target_os = "linux",
target_os = "android"),
target_arch = "x86_64")) {
"Linux x86_64"
} else if cfg!(all(any(target_os = "linux",
target_os = "android"),
target_arch = "x86")) {
"Linux i686"
} else {
""
} |
|
Didn't know that. This will probably be better. Thanks. |
|
Hm, with my current approach, it won't compile if the platform is not listed. So any port to a new platform requires adding a string for |
|
Good point; seems like a good thing to me too. |
|
https://html.spec.whatwg.org/multipage/webappapis.html#dom-navigator-platform
Couldn't we just emit a constant? |
What do you mean? |
|
I mean to always return the same thing. Even on different plateforms. At the very least I am not sure the architecture is important to include.
|
This is how it works now. It always returns an empty string.
For browser.html, we need |
|
I removed the architecture string. |
|
-S-awaiting-review +S-needs-code-changes +@jdm Reviewed 1 of 1 files at r1, 3 of 3 files at r2. tests/wpt/mozilla/meta/mozilla/navigator.html.ini, line 6 [r2] (raw file): tests/wpt/mozilla/meta/mozilla/navigator.html.ini, line 11 [r2] (raw file): Comments from the review on Reviewable.io |
Do you mean that browser.html will reimplement input methods etc in JS land? Won't that have the same insane amount of issues like the Atom editor suffers from? https://github.com/andischerer/atom-keyboard-localization/issues |
No. By “keybinding”, I refer to things like “Cmd-T” (which has nothing to do with text input), and "window controls” refers to the close|max|min buttons of a window. |
paulrouget
force-pushed the
paulrouget:navigator.platform
branch
from
6836db0
to
6b49651
|
review ping |
|
@bors-servo: r+ Reviewed 2 of 2 files at r3. Comments from the review on Reviewable.io |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
|
|
|
|
implement navigator.platform Fix #7573 I used this as a reference: http://stackoverflow.com/questions/19877924/what-is-the-list-of-possible-values-for-navigator-platform-as-of-today <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7582) <!-- Reviewable:end -->
|
|
|
implement navigator.platform Fix #7573 I used this as a reference: http://stackoverflow.com/questions/19877924/what-is-the-list-of-possible-values-for-navigator-platform-as-of-today <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7582) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
implement navigator.platform Fix #7573 I used this as a reference: http://stackoverflow.com/questions/19877924/what-is-the-list-of-possible-values-for-navigator-platform-as-of-today <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7582) <!-- Reviewable:end -->
|
|
|
Intermittent? /html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.hex.html |
|
@bors-servo retry |
implement navigator.platform Fix #7573 I used this as a reference: http://stackoverflow.com/questions/19877924/what-is-the-list-of-possible-values-for-navigator-platform-as-of-today <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7582) <!-- Reviewable:end -->
|
|
|
Infrastructure failure; hold tight. |
|
@bors-servo retry
|
|
|
|
|
paulrouget commentedSep 9, 2015
Fix #7573
I used this as a reference: http://stackoverflow.com/questions/19877924/what-is-the-list-of-possible-values-for-navigator-platform-as-of-today