Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually store the overflow for inline-block elements. #7588

Merged
merged 1 commit into from Sep 17, 2015
Merged

Actually store the overflow for inline-block elements. #7588

merged 1 commit into from Sep 17, 2015
+72 −6

Conversation

@notriddle
Copy link
Contributor

notriddle commented Sep 9, 2015

Fixes #7571

Review on Reviewable
@notriddle
Actually store the overflow for inline-block elements.
Loading status checks…
029af81 
Fixes #7571
@notriddle
Copy link
Contributor Author

notriddle commented Sep 9, 2015

r? @pcwalton
@notriddle
Copy link
Contributor Author

notriddle commented Sep 11, 2015

r? @jdm
@highfive highfive assigned jdm and unassigned pcwalton Sep 11, 2015
@jdm
Copy link
Member

jdm commented Sep 11, 2015

Sorry, I'm no good for reviewing layout code. Let's try @mbrubeck.
@notriddle
Copy link
Contributor Author

notriddle commented Sep 11, 2015

Alright, then. r? @mbrubeck
@highfive highfive assigned mbrubeck and unassigned jdm Sep 11, 2015
@pcwalton
Copy link
Contributor

pcwalton commented Sep 15, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2015

📌 Commit 029af81 has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2015

⌛ Testing commit 029af81 with merge 578815c...
bors-servo pushed a commit that referenced this pull request Sep 15, 2015
bors-servo
Auto merge of #7588 - notriddle:master, r=pcwalton
578815c 
Actually store the overflow for inline-block elements.

Fixes #7571

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7588)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2015

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Sep 15, 2015

Sorry, this is #7625 again. We'll sort it out.
@notriddle
Copy link
Contributor Author

notriddle commented Sep 17, 2015

@bors-servo retry
@jdm
Copy link
Member

jdm commented Sep 17, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2015

⌛ Testing commit 029af81 with merge 53670e6...
bors-servo pushed a commit that referenced this pull request Sep 17, 2015
bors-servo
Auto merge of #7588 - notriddle:master, r=pcwalton
53670e6 
Actually store the overflow for inline-block elements.

Fixes #7571

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7588)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2015

💔 Test failed - mac-rel-wpt
@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 17, 2015

@bors-servo retry

#7422
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2015

⌛ Testing commit 029af81 with merge 9e914ca...
bors-servo pushed a commit that referenced this pull request Sep 17, 2015
bors-servo
Auto merge of #7588 - notriddle:master, r=pcwalton
Loading status checks…
9e914ca 
Actually store the overflow for inline-block elements.

Fixes #7571

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7588)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 029af81 into servo:master Sep 17, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@notriddle @jdm @pcwalton @bors-servo @mbrubeck @highfive
You can’t perform that action at this time.