Improve DOM interfaces' extended attributes #7601

nox · 2015-09-11T01:08:31Z

Some should have been [SameObject] instead of [Constant]. The rest of the changes are additional [Constant] and [Pure] extended attributes on many operations.


        Fix Node.childNodes attributes


        Fix ParentNode missing attributes

ParentNode.children is [SameObject], querySelectorAll() is [NewObject].


        Fix Element missing attributes

Attributes classList and attributes are [SameObject].


        Fix NodeIterator.root attributes

It should be [SameObject].

Ms2ger · 2015-09-11T19:09:24Z

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, 2 of 18 files at r5.
Review status: 2 of 18 files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io

Ms2ger · 2015-09-18T14:16:11Z

Reviewed 16 of 18 files at r5.
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

^{components/script/dom/webidls/Event.webidl, line 15 [r5] (raw file):}
Gotcha! initEvent can break this. Try if you can write a test.

^{components/script/dom/webidls/NodeIterator.webidl, line 23 [r5] (raw file):}
"Attributes/methods flagged in this way promise that they will keep returning the same value as long as nothing that has [Affects=Everything] executes."

These two always return another node.

Comments from the review on Reviewable.io

Ms2ger · 2015-09-19T14:01:08Z

Reviewed 16 of 18 files at r5.
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

^{components/script/dom/webidls/Event.webidl, line 15 [r5] (raw file):}
Gotcha! initEvent can break this. Try if you can write a test.

^{components/script/dom/webidls/NodeIterator.webidl, line 23 [r5] (raw file):}
"Attributes/methods flagged in this way promise that they will keep returning the same value as long as nothing that has [Affects=Everything] executes."

These two always return another node.

Comments from the review on Reviewable.io


        Annotate many DOM attribute and methods with [Constant] and [Pure]

nox · 2015-09-19T14:04:10Z

@Ms2ger Amended.

Review status: 16 of 18 files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from the review on Reviewable.io

Ms2ger · 2015-09-19T14:20:54Z

@bors-servo r+

-S-awaiting-review +S-awaiting-merge

Reviewed 2 of 2 files at r6.
Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io

bors-servo · 2015-09-19T14:20:56Z

📌 Commit 49219ba has been approved by Ms2ger

bors-servo · 2015-09-19T14:20:59Z

⌛ Testing commit 49219ba with merge b6ec98b...


        Auto merge of #7601 - nox:cleanup-dom-webidls, r=Ms2ger

Improve DOM interfaces' extended attributes Some should have been `[SameObject]` instead of `[Constant]`. The rest of the changes are additional `[Constant]` and `[Pure]` extended attributes on many operations.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7601)

bors-servo · 2015-09-19T14:26:28Z

💔 Test failed - mac-rel-wpt

nox · 2015-09-19T14:27:57Z

Agreeing to the Xcode/iOS license requires admin privileges, please re-run as root via sudo.

@larsbergstrom?

larsbergstrom · 2015-09-19T14:42:56Z

Gah! I won't be around a computer with ssh for another six hours. @metajack
@edunham?

On Sep 19, 2015, at 9:28 AM, Anthony Ramine notifications@github.com
wrote:

Agreeing to the Xcode/iOS license requires admin privileges, please
re-run as root via sudo.

@larsbergstrom https://github.com/larsbergstrom?

—
Reply to this email directly or view it on GitHub
#7601 (comment).

larsbergstrom · 2015-09-19T22:48:21Z

@bors-servo retry

bors-servo · 2015-09-19T22:48:22Z

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...

bors-servo · 2015-09-19T23:18:32Z

💔 Test failed - mac-rel-wpt

nox · 2015-09-19T23:50:20Z

@bors-servo retry

#7422

bors-servo · 2015-09-19T23:50:24Z

⌛ Testing commit 49219ba with merge 61267cd...


        Auto merge of #7601 - nox:cleanup-dom-webidls, r=Ms2ger

Improve DOM interfaces' extended attributes Some should have been `[SameObject]` instead of `[Constant]`. The rest of the changes are additional `[Constant]` and `[Pure]` extended attributes on many operations.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7601)

bors-servo · 2015-09-20T00:29:39Z

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

nox added 4 commits Sep 11, 2015

Fix Node.childNodes attributes

a33e5f9

Fix ParentNode missing attributes

42254ba

ParentNode.children is [SameObject], querySelectorAll() is [NewObject].

Fix Element missing attributes

d93c8da

Attributes classList and attributes are [SameObject].

Fix NodeIterator.root attributes

4dbf391

It should be [SameObject].

highfive added the S-awaiting-review label Sep 11, 2015

nox added A-content/dom A-content/bindings and removed S-awaiting-review labels Sep 11, 2015

nox force-pushed the nox:cleanup-dom-webidls branch from 0f10af5 to 46f3841 Sep 11, 2015

highfive added the S-awaiting-review label Sep 11, 2015

nox mentioned this pull request Sep 11, 2015

Reviewable fails to load an inconspicuous PR Reviewable/Reviewable#164

Closed

nox assigned Ms2ger Sep 12, 2015

Annotate many DOM attribute and methods with [Constant] and [Pure]

Loading status checks…

49219ba

nox force-pushed the nox:cleanup-dom-webidls branch from 46f3841 to 49219ba Sep 19, 2015

Ms2ger added S-awaiting-merge and removed S-awaiting-review labels Sep 19, 2015

highfive added S-tests-failed and removed S-awaiting-merge labels Sep 19, 2015

highfive added S-awaiting-merge and removed S-tests-failed labels Sep 19, 2015

This was referenced Sep 20, 2015

webgl: Support texImage2D with a canvas as an argument #7682

Merged

Implement `size` attribute for <font> element #7683

Merged

bors-servo merged commit 49219ba into servo:master Sep 20, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

nox mentioned this pull request Sep 21, 2015

Low hanging Dromaeo fruit #6900

Closed

nox deleted the nox:cleanup-dom-webidls branch Sep 23, 2015

saschanaz mentioned this pull request Oct 25, 2019

Support IDL stringifier attributes #24544

Merged

4 of 4 tasks complete

servo / servo

Improve DOM interfaces' extended attributes #7601

Improve DOM interfaces' extended attributes #7601

nox commented Sep 11, 2015

Ms2ger commented Sep 11, 2015

Ms2ger commented Sep 18, 2015

Ms2ger commented Sep 19, 2015

nox commented Sep 19, 2015

Ms2ger commented Sep 19, 2015

bors-servo commented Sep 19, 2015

bors-servo commented Sep 19, 2015

bors-servo commented Sep 19, 2015

nox commented Sep 19, 2015

larsbergstrom commented Sep 19, 2015

larsbergstrom commented Sep 19, 2015

bors-servo commented Sep 19, 2015

bors-servo commented Sep 19, 2015

nox commented Sep 19, 2015

bors-servo commented Sep 19, 2015

bors-servo commented Sep 20, 2015

servo / servo

Join GitHub today

Improve DOM interfaces' extended attributes #7601

Improve DOM interfaces' extended attributes #7601

Conversation

nox commented Sep 11, 2015

Ms2ger commented Sep 11, 2015

Ms2ger commented Sep 18, 2015

Ms2ger commented Sep 19, 2015

nox commented Sep 19, 2015

Ms2ger commented Sep 19, 2015

bors-servo commented Sep 19, 2015

bors-servo commented Sep 19, 2015

bors-servo commented Sep 19, 2015

nox commented Sep 19, 2015

larsbergstrom commented Sep 19, 2015

larsbergstrom commented Sep 19, 2015

bors-servo commented Sep 19, 2015

bors-servo commented Sep 19, 2015

nox commented Sep 19, 2015

bors-servo commented Sep 19, 2015

bors-servo commented Sep 20, 2015