Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the type_id fields to DOMClass #7606

Merged
merged 2 commits into from Sep 13, 2015
Merged

Move the type_id fields to DOMClass #7606

merged 2 commits into from Sep 13, 2015

Conversation

@nox
Copy link
Member

nox commented Sep 11, 2015

Cc @michaelwu.

Review on Reviewable
@highfive
Copy link

highfive commented Sep 11, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@nox nox mentioned this pull request Sep 11, 2015
Closed
@michaelwu @nox
Move EventTargetTypeId/NodeTypeId to DOMClass
941f7dc
@nox nox force-pushed the nox:move-typeid branch from 90702c9 to d3b1379 Sep 11, 2015
@nox
Copy link
Member Author

nox commented Sep 13, 2015

Oh I forgot to mark XmlHttpRequestEventTarget as [Abstract].
@jdm
Copy link
Member

jdm commented Sep 13, 2015

WorkerGlobalScope needs it, too.
@nox
Copy link
Member Author

nox commented Sep 13, 2015

@jdm Thanks for noticing this, r?
@nox nox force-pushed the nox:move-typeid branch from d3b1379 to 125a96c Sep 13, 2015
@nox
Introduce [Abstract] to mark non-leaf interfaces
Loading status checks…
c25085f 
Some interfaces like Node, CharacterData and HTMLTableCellElement are never
instantiated directly, only their descendant interfaces are. Those are marked
with [Abstract] to set their type_id to None instead of having dummy values
in the TypeId enums.
@nox nox force-pushed the nox:move-typeid branch from 125a96c to c25085f Sep 13, 2015
@jdm
Copy link
Member

jdm commented Sep 13, 2015

@bors-servo: r+
Looks good! Thanks for cleaning this up.
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2015

📌 Commit c25085f has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2015

⌛ Testing commit c25085f with merge d5ee58c...
bors-servo pushed a commit that referenced this pull request Sep 13, 2015
bors-servo
Auto merge of #7606 - nox:move-typeid, r=jdm
Loading status checks…
d5ee58c 
Move the type_id fields to DOMClass

Cc @michaelwu.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7606)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 13, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit c25085f into servo:master Sep 13, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Sep 13, 2015
Merged
@nox nox deleted the nox:move-typeid branch Sep 13, 2015
@michaelwu
Copy link
Contributor

michaelwu commented Sep 13, 2015

Thanks for getting this done!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-content/bindings A-content/dom S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @jdm @bors-servo @michaelwu
You can’t perform that action at this time.