Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match forwarded events as atoms, fixes #7495 #7623

Merged
merged 1 commit into from Sep 16, 2015
Merged

Match forwarded events as atoms, fixes #7495 #7623

merged 1 commit into from Sep 16, 2015

Conversation

@aidanhs
Copy link
Contributor

aidanhs commented Sep 14, 2015

Hopefully I understood the issue correctly...

Review on Reviewable
@aidanhs
Match forwarded events as atoms, fixes #7495
Loading status checks…
d1fcbca
@highfive
Copy link

highfive commented Sep 14, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon.
@nox nox self-assigned this Sep 14, 2015
@nox
Copy link
Member

nox commented Sep 14, 2015

@bors-servo r+

@aidanhs Thanks for your contribution.
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2015

📌 Commit d1fcbca has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2015

⌛ Testing commit d1fcbca with merge b6ad17a...
bors-servo pushed a commit that referenced this pull request Sep 14, 2015
bors-servo
Auto merge of #7623 - aidanhs:aphs-atomise-forwarded-events, r=nox
b6ad17a 
Match forwarded events as atoms, fixes #7495

Hopefully I understood the issue correctly...

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7623)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2015

💔 Test failed - linux-rel
@nox
Copy link
Member

nox commented Sep 14, 2015 

Unexpected Results
==================

/css21_dev/html4/font-family-013.htm
------------------------------------
FAIL [Parent]
/css21_dev/html4/fonts-013.htm
------------------------------
FAIL [Parent]
@nox
Copy link
Member

nox commented Sep 14, 2015

Probably an intermittent failure, @jdm is looking into it.
@jdm
Copy link
Member

jdm commented Sep 14, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2015

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@nox nox added S-awaiting-merge and removed S-tests-failed labels Sep 14, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2015

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Sep 14, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2015

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@SimonSapin
Copy link
Member

SimonSapin commented Sep 14, 2015

font-family-013.htm and fonts-013.htm were failing until we installed some Microsoft fonts on the builders. Could this have regressed? CC @larsbergstrom
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2015

💔 Test failed - linux-rel
@aidanhs
Copy link
Contributor Author

aidanhs commented Sep 15, 2015

Worth a retry? I note some other PRs have been merged successfully.
@nox
Copy link
Member

nox commented Sep 15, 2015

@bors-servo retry

@aidanhs Yes.
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2015

⌛ Testing commit d1fcbca with merge f670d4a...
bors-servo pushed a commit that referenced this pull request Sep 15, 2015
bors-servo
Auto merge of #7623 - aidanhs:aphs-atomise-forwarded-events, r=nox
f670d4a 
Match forwarded events as atoms, fixes #7495

Hopefully I understood the issue correctly...

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7623)
<!-- Reviewable:end -->
@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 15, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2015

⌛ Testing commit d1fcbca with merge b3aad7b...
bors-servo pushed a commit that referenced this pull request Sep 15, 2015
bors-servo
Auto merge of #7623 - aidanhs:aphs-atomise-forwarded-events, r=nox
b3aad7b 
Match forwarded events as atoms, fixes #7495

Hopefully I understood the issue correctly...

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7623)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2015

💔 Test failed - linux-dev-wpt
@aidanhs
Copy link
Contributor Author

aidanhs commented Sep 15, 2015 

 scheduler: IFRAMEs added with DOM
----------------------------------
Expected PASS, got FAIL
assert_array_equals: lengths differ, expected 5 got 3

assert_array_equals: lengths differ, expected 5 got 3
test@http://localhost:8000/old-tests/submission/Opera/script_scheduling/039.html:5:1
Test.prototype.step@http://localhost:8000/resources/testharness.js:1379:20
Test.prototype.step_func/<@http://localhost:8000/resources/testharness.js:1403:1
[...]
Unexpected results: 22 (FAIL: 1, PASS: 1, TIMEOUT: 20)
[...]
/old-tests/submission/Opera/script_scheduling/039.html
------------------------------------------------------
FAIL  scheduler: IFRAMEs added with DOM

I note that test did:

        onload = t.step_func(function() {
                setTimeout(t.step_func(test), 200);
        });

Buildbot running too slowly so frames didn't load before 200ms?
@aidanhs aidanhs mentioned this pull request Sep 15, 2015
Open
@aidanhs
Copy link
Contributor Author

aidanhs commented Sep 15, 2015

Ready for retry following servo/saltfs#116?
@jdm
Copy link
Member

jdm commented Sep 15, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2015

⌛ Testing commit d1fcbca with merge 4935323...
bors-servo pushed a commit that referenced this pull request Sep 15, 2015
bors-servo
Auto merge of #7623 - aidanhs:aphs-atomise-forwarded-events, r=nox
Loading status checks…
4935323 
Match forwarded events as atoms, fixes #7495

Hopefully I understood the issue correctly...

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7623)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 15, 2015

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Sep 15, 2015

This is #7625 and #7437. We'll get this sorted out.
@nox
Copy link
Member

nox commented Sep 16, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 16, 2015

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 16, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit d1fcbca into servo:master Sep 16, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@aidanhs aidanhs deleted the aidanhs:aphs-atomise-forwarded-events branch Sep 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@aidanhs @highfive @nox @bors-servo @jdm @SimonSapin @Ms2ger
You can’t perform that action at this time.