Move HSTS/CookieStorage to Arc<RwLock> from Ipc

[samfoo]

#7421

[bors-servo]

☔ The latest upstream changes (presumably #7447) made this pull request unmergeable. Please resolve the merge conflicts.

[jdm]

Looking pretty good!
-S-awaiting-review +S-needs-code-changes

---

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, 13 unresolved discussions, some commit checks failed.

---

^{components/net/http_loader.rs, line 326 [r1] (raw file):}
nit: &Arc

---

^{components/net/http_loader.rs, line 335 [r1] (raw file):}
nit: &Arc

---

^{components/net/http_loader.rs, line 351 [r1] (raw file):}
nit: &Arc

---

^{components/net/http_loader.rs, line 363 [r1] (raw file):}
nit: &Arc

---

^{components/net/http_loader.rs, line 504 [r1] (raw file):}
I think I'd still prefer the request_must_be_secured abstraction instead of inlining this here.

---

^{components/net/resource_task.rs, line 166 [r1] (raw file):}
Is this clone necessary?

---

^{components/net/resource_task.rs, line 167 [r1] (raw file):}
This could use read instad, right?

---

^{components/net/resource_task.rs, line 208 [r1] (raw file):}
Is this clone necessary?

---

^{tests/unit/net/hsts.rs, line 15 [r1] (raw file):}
Why remove this test?

---

^{tests/unit/net/http_loader.rs, line 180 [r1] (raw file):}
This can be read, right?

---

^{tests/unit/net/http_loader.rs, line 401 [r1] (raw file):}
Why's this clone necessary?

---

^{tests/unit/net/http_loader.rs, line 434 [r1] (raw file):}
Unnecessary clone?

---

^{tests/unit/net/http_loader.rs, line 484 [r1] (raw file):}
Let's reuse url.

---

Comments from the review on Reviewable.io

[samfoo]

Review status: all files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.

---

^{components/net/resource_task.rs, line 167 [r1] (raw file):}
Very confusingly, no. CookieStorage::cookies_for_url takes &mut self. I haven't investigated why.

---

^{tests/unit/net/hsts.rs, line 15 [r1] (raw file):}
The resource manager is now just responsible for owning the HSTS list. Adding and removing entries is only done on the list, rather than through the manager. This test no longer is really testing anything.

---

^{tests/unit/net/http_loader.rs, line 180 [r1] (raw file):}
Same as above.

---

^{tests/unit/net/http_loader.rs, line 401 [r1] (raw file):}
Load consumes hsts_list by value. The assertion on the line below needs to use the list again. In this case, cloning an Arc shouldn't matter anyway, right? It's not really cloning the list, just the pointer?

---

^{tests/unit/net/http_loader.rs, line 434 [r1] (raw file):}
Same as above.

---

Comments from the review on Reviewable.io

[jdm]

-S-awaiting-review -S-needs-rebase +S-needs-code-changes

---

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

---

^{components/net/resource_task.rs, line 167 [r1] (raw file):}
Oh right, we update the last used time in the cookies that get retrieved.

---

^{tests/unit/net/http_loader.rs, line 401 [r1] (raw file):}
load consumes the result of hsts_list.clone(), and hsts_list remains unconsumed.

---

Comments from the review on Reviewable.io

[samfoo]

Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

---

^{tests/unit/net/http_loader.rs, line 401 [r1] (raw file):}
Whoops, you're right! I got a bit carried away there. Fixed.

---

Comments from the review on Reviewable.io

[samfoo]

Review status: 5 of 6 files reviewed at latest revision, 2 unresolved discussions, some commit checks pending.

---

^{tests/unit/net/http_loader.rs, line 434 [r1] (raw file):}
Removed, as above.

---

Comments from the review on Reviewable.io

[jdm]

@bors-servo: r+

---

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

---

Comments from the review on Reviewable.io

[bors-servo]

📌 Commit 6411192 has been approved by jdm

[bors-servo]

⌛ Testing commit 6411192 with merge 7f2d819...

[bors-servo]

💔 Test failed - mac-rel-wpt

[jdm]

@bors-servo: retry

• #7422

[bors-servo]

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only linux-rel, mac-rel-wpt...

[bors-servo]

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt