Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap to screen pixels instead of px #7667

Merged
merged 2 commits into from Sep 18, 2015
Merged

Snap to screen pixels instead of px #7667

merged 2 commits into from Sep 18, 2015
+143 −78

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 18, 2015

Fixes #7665. r? @glennw

Review on Reviewable
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Sep 18, 2015

Note: I haven't tested this on an actual retina-style display, but I simulated it by zooming and by using --device-pixel-ratio.

Also, I forgot to add a test, which I'll do shortly.
@mbrubeck
Allow setting device-pixel-ratio for reftests
186ab5a
@mbrubeck mbrubeck force-pushed the mbrubeck:oh-snap branch from 0617bd6 to aec4409 Sep 18, 2015
components/gfx/paint_context.rs Outdated
@@ -1601,7 +1619,7 @@ impl ToAzureSize for Size2D<Au> {
}

impl ToAzureSize for AzIntSize {
fn to_nearest_azure_size(&self) -> Size2D<AzFloat> {
fn to_nearest_azure_size(&self, _: f32) -> Size2D<AzFloat> {

This comment has been minimized.

Sign in to view
@glennw

glennw Sep 18, 2015

Member

Shouldn't this also apply the scale?
@mbrubeck mbrubeck force-pushed the mbrubeck:oh-snap branch from aec4409 to fc883c6 Sep 18, 2015
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Sep 18, 2015

AzIntSize::to_nearest_azure_size was dead code. Removed in the latest version.
@mbrubeck
Snap to screen pixels instead of px
Loading status checks…
9333f02 
Fixes #7665.
@mbrubeck mbrubeck force-pushed the mbrubeck:oh-snap branch from fc883c6 to 9333f02 Sep 18, 2015
@glennw
Copy link
Member

glennw commented Sep 18, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2015

📌 Commit 9333f02 has been approved by glennw
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2015

⌛ Testing commit 9333f02 with merge 491d62c...
bors-servo pushed a commit that referenced this pull request Sep 18, 2015
bors-servo
Auto merge of #7667 - mbrubeck:oh-snap, r=glennw
Loading status checks…
491d62c 
Snap to screen pixels instead of px

Fixes #7665. r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7667)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2015

💔 Test failed - mac-rel-wpt
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Sep 18, 2015

@bors-servo retry

#7422
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2015

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 9333f02 into servo:master Sep 18, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mbrubeck mbrubeck mentioned this pull request Nov 4, 2015
Closed
@mbrubeck mbrubeck deleted the mbrubeck:oh-snap branch May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@mbrubeck @glennw @bors-servo @SimonSapin @highfive
You can’t perform that action at this time.