Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace twitter fail whale with redirect to archive.org version #7685

Merged
merged 1 commit into from Sep 25, 2015
Merged

Replace twitter fail whale with redirect to archive.org version #7685

merged 1 commit into from Sep 25, 2015
+2 −1,345

Conversation

@bjwbell
Copy link
Contributor

bjwbell commented Sep 20, 2015

Sorry @pcwalton should have gotten the attribution approved first (https://twitter.com/subcide/status/645149674546966528)

r? @pcwalton

Review on Reviewable
@bjwbell
Copy link
Contributor Author

bjwbell commented Sep 20, 2015

follow up tweet with author https://twitter.com/bjwbell/status/645453144906829825
@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 20, 2015

I would prefer removing the file if it's not freely licensed.
@bjwbell
Copy link
Contributor Author

bjwbell commented Sep 21, 2015

@Ms2ger what do you think about bjwbell@62f8ecd?
(I know servo doesn't currently do redirects)
@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 22, 2015

Probably fine.
@bjwbell
Copy link
Contributor Author

bjwbell commented Sep 22, 2015

@pcwalton can you r+?
@bjwbell
Replace twitter fail whale with redirect to archive.org version
Loading status checks…
3e25284 
Also add link to archive.org page of twitter fail whale
@bjwbell bjwbell force-pushed the bjwbell:add-twitter-fail-whale-attribution branch from 0252d99 to 3e25284 Sep 22, 2015
@bjwbell bjwbell changed the title Add twitter fail whale attribution Replace twitter fail whale with redirect to archive.org version Sep 22, 2015
@pcwalton
Copy link
Contributor

pcwalton commented Sep 25, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2015

📌 Commit 3e25284 has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2015

⌛ Testing commit 3e25284 with merge 8909a92...
bors-servo pushed a commit that referenced this pull request Sep 25, 2015
bors-servo
Auto merge of #7685 - bjwbell:add-twitter-fail-whale-attribution, r=p…
8909a92 
…cwalton

Replace twitter fail whale with redirect to archive.org version

Sorry @pcwalton should have gotten the attribution approved first (https://twitter.com/subcide/status/645149674546966528)

r? @pcwalton

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7685)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2015

💔 Test failed - linux-dev
@bjwbell
Copy link
Contributor Author

bjwbell commented Sep 25, 2015

test ref timeout.

@pcwalton I guess retry bors.
@jdm
Copy link
Member

jdm commented Sep 25, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2015

⌛ Testing commit 3e25284 with merge b26fac3...
bors-servo pushed a commit that referenced this pull request Sep 25, 2015
bors-servo
Auto merge of #7685 - bjwbell:add-twitter-fail-whale-attribution, r=p…
Loading status checks…
b26fac3 
…cwalton

Replace twitter fail whale with redirect to archive.org version

Sorry @pcwalton should have gotten the attribution approved first (https://twitter.com/subcide/status/645149674546966528)

r? @pcwalton

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7685)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2015

💔 Test failed - mac-rel-wpt
@jdm
Copy link
Member

jdm commented Sep 25, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2015

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 3e25284 into servo:master Sep 25, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bjwbell bjwbell deleted the bjwbell:add-twitter-fail-whale-attribution branch Sep 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@bjwbell @Ms2ger @pcwalton @bors-servo @jdm @SimonSapin @highfive
You can’t perform that action at this time.