HTMLTableSectionElement improvements

[frewsxcv]

'thead' and 'tfoot' now create instances of HTMLTableSectionElement

HTMLTableSectionElement.rows has been implemented

[nox]

-S-awaiting-review +S-needs-code-changes

---

Review status: 0 of 10 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

^{components/script/dom/htmltablesectionelement.rs, line 61 [r1] (raw file):}
This won't do, that filter traverses all descendants, not just children. There is nothing to limit to children in HTMLCollection currently. Include a test with nested tables.

---

Comments from the review on Reviewable.io

[nox]

Reviewed 10 of 10 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

Comments from the review on Reviewable.io

[frewsxcv]

^{components/script/dom/htmltablesectionelement.rs, line 61 [r1] (raw file):}
Good catch

---

Comments from the review on Reviewable.io

[dzbarsky]

Do you want to just drive in #6936? I don't have enough time these days =/

[frewsxcv]

@dzbarsky Once this gets merged, I can take ownership of that PR if you want.

[frewsxcv]

Comments have been addressed

[frewsxcv]

Rebased to address merge conflicts

[nox]

-S-awaiting-review +S-awaiting-answer

---

Reviewed 4 of 4 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

---

^{components/script/dom/htmltablesectionelement.rs, line 61 [r1] (raw file):}
@jdm Should we implement .rows like this now or wait for a less dumb HTMLCollection infrastructure that can avoid traversing whole trees?

---

Comments from the review on Reviewable.io

[jdm]

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

^{components/script/dom/htmltablesectionelement.rs, line 61 [r1] (raw file):}
I don't see a compelling reason to wait.

---

Comments from the review on Reviewable.io

[nox]

@bors-servo r+

[bors-servo]

📌 Commit adbcb53 has been approved by nox

[bors-servo]

⌛ Testing commit adbcb53 with merge 9105f34...

[bors-servo]

💔 Test failed - linux-rel

[frewsxcv]

That test passes for me locally. Intermittent fail? If so, anyone know what issue it is?

EDIT: ....or if there is an issue for it

[jdm]

@bors-servo: retry

• #7846

[bors-servo]

⌛ Testing commit adbcb53 with merge 9eb0eff...

[bors-servo]

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt