Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tool for comparing Dromaeo outputs #7759

Merged
merged 1 commit into from Sep 30, 2015
Merged

Add a tool for comparing Dromaeo outputs #7759

merged 1 commit into from Sep 30, 2015

Conversation

@jdramani
Copy link
Contributor

jdramani commented Sep 27, 2015

Review on Reviewable
@jdramani
fix issue#6888
Loading status checks…
19be6f9
@jdramani
Copy link
Contributor Author

jdramani commented Sep 27, 2015

I have not added a class for formatting terminal outputs. But if you want me to add then pls let me know where it should go.
@nox nox changed the title fix issue#6888 Add a tool for comparing Dromaeo outputs Sep 27, 2015
@nox nox mentioned this pull request Sep 27, 2015
Closed
@nox
Copy link
Member

nox commented Sep 27, 2015

Nice work! I can't wait to see this integrated somehow to our continuous integration platform.
@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 30, 2015

Reviewed 1 of 1 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io
@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 30, 2015

@bors-servo r+

Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Sep 30, 2015

📌 Commit 19be6f9 has been approved by mbrubeck
@mbrubeck mbrubeck self-assigned this Sep 30, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Sep 30, 2015

⌛ Testing commit 19be6f9 with merge 2049357...
bors-servo pushed a commit that referenced this pull request Sep 30, 2015
bors-servo
Auto merge of #7759 - jdramani:cmp_dromaeo_output_tool, r=mbrubeck
Loading status checks…
2049357 
Add a tool for comparing Dromaeo outputs



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7759)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 30, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 19be6f9 into servo:master Sep 30, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@jdramani jdramani deleted the jdramani:cmp_dromaeo_output_tool branch Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
A-mach L-python S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdramani @nox @mbrubeck @bors-servo @highfive
You can’t perform that action at this time.