Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upOnly display text carets in text inputs #7764
Conversation
highfive
commented
Sep 27, 2015
|
|
|
Can we reftest this? |
|
For example, by focusing a submit button with JS and checking to make sure no caret shows up. |
j3parker
force-pushed the
j3parker:input-caret-only-for-text
branch
from
189052a
to
9177530
|
I can do that! I can't think of a good way to reftest that there is no caret in the buttons at all (i.e. that reftest seems like it'd still pass before these changes) |
|
Would it still pass even if you focus the buttons with JS? |
j3parker
force-pushed the
j3parker:input-caret-only-for-text
branch
from
9177530
to
9cf4387
|
@pcwalton is this what you had in mind? It fails before the change and passes after. I had to add some css to make them match because of servo.css; I'm not sure if that's cool. I tried to do it in the least opinionated way I could. |
|
(The focusing is unnecessary for the test, though... the caret shows up even unfocused) |
|
@j3parker That looks great, thank you! |
|
@bors-servo: r+ |
|
|
Only display text carets in text inputs For #7756 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7764) <!-- Reviewable:end -->
|
@bors-servo retry
|
Only display text carets in text inputs For #7756 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7764) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
Only display text carets in text inputs For #7756 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7764) <!-- Reviewable:end -->
|
|
j3parker commentedSep 27, 2015
For #7756