Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build notifications in Python 2.x on Linux #7769

Merged
merged 1 commit into from Sep 28, 2015

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 28, 2015

In Python 2.x on Linux, sys.platform == 'linux2'.

https://docs.python.org/2/library/sys.html#sys.platform

r? @frewsxcv

Review on Reviewable

In Python 2.x on Linux, `sys.platform == 'linux2'`.

https://docs.python.org/2/library/sys.html#sys.platform
@frewsxcv
Copy link
Member

frewsxcv commented Sep 28, 2015

Good catch!

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2015

📌 Commit aa7e9dd has been approved by frewsxcv

@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2015

Testing commit aa7e9dd with merge e78a8ee...

bors-servo pushed a commit that referenced this pull request Sep 28, 2015
Fix build notifications in Python 2.x on Linux

In Python 2.x on Linux, `sys.platform == 'linux2'`.

https://docs.python.org/2/library/sys.html#sys.platform

r? @frewsxcv

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7769)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2015

💔 Test failed - mac-rel-wpt

@frewsxcv
Copy link
Member

frewsxcv commented Sep 28, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2015

Testing commit aa7e9dd with merge 076f44a...

bors-servo pushed a commit that referenced this pull request Sep 28, 2015
Fix build notifications in Python 2.x on Linux

In Python 2.x on Linux, `sys.platform == 'linux2'`.

https://docs.python.org/2/library/sys.html#sys.platform

r? @frewsxcv

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7769)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2015

@bors-servo bors-servo merged commit aa7e9dd into servo:master Sep 28, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mbrubeck mbrubeck deleted the mbrubeck:notify-linux2 branch May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.