Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAvoid allocations when joining strings #7776
Merged
Conversation
frewsxcv
changed the title
|
Reviewed 1 of 1 files at r1, 4 of 4 files at r2. Comments from the review on Reviewable.io |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
|
@bors-servo r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Sep 29, 2015
Avoid allocations when joining strings <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7776) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Sep 29, 2015
Avoid allocations when joining strings <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7776) <!-- Reviewable:end -->
|
|
|
This changes behaviour in the face of empty strings in the iterator, I think. Did you confirm that can't happen? |
|
How does the behavior change with empty strings? |
|
Joining |
|
Ah, that's what you meant. I'm not sure about cssstyledeclaration.rs, but with the other two DOM instances, I think we're just going to eventually strip away the whitespace (they're being joined together by |
|
In cssstyledeclaration, this is run on the result of |
|
I'm planning to open a PR later that will make |
frewsxcv
added a commit
to frewsxcv/servo
that referenced
this pull request
Sep 30, 2015
Prior to this commit, `str_join` would skip empty items at the start of the `Iterator` until it found a non-empty item. This contradicts `SliceConcatExt::join` which doesn't skip anything. Brought up in: servo#7776 (comment)
|
PR opened #7806 |
bors-servo
pushed a commit
that referenced
this pull request
Oct 1, 2015
Make util::str::str_join consistent with SliceConcatExt::join Prior to this commit, `str_join` would skip empty items at the start of the `Iterator` until it found a non-empty item. This contradicts `SliceConcatExt::join` which doesn't skip anything. Brought up in: #7776 (comment) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7806) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this pull request
Oct 1, 2015
Make util::str::str_join consistent with SliceConcatExt::join Prior to this commit, `str_join` would skip empty items at the start of the `Iterator` until it found a non-empty item. This contradicts `SliceConcatExt::join` which doesn't skip anything. Brought up in: #7776 (comment) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7806) <!-- Reviewable:end -->
jrmuizel
pushed a commit
to jrmuizel/gecko-cinnabar
that referenced
this pull request
Jun 12, 2017
…ncatExt::join (from frewsxcv:consistent-str-join); r=mbrubeck Prior to this commit, `str_join` would skip empty items at the start of the `Iterator` until it found a non-empty item. This contradicts `SliceConcatExt::join` which doesn't skip anything. Brought up in: servo/servo#7776 (comment) Source-Repo: https://github.com/servo/servo Source-Revision: 520c907742afbb94085c6b5e62156a5457530010
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 30, 2019
…ncatExt::join (from frewsxcv:consistent-str-join); r=mbrubeck Prior to this commit, `str_join` would skip empty items at the start of the `Iterator` until it found a non-empty item. This contradicts `SliceConcatExt::join` which doesn't skip anything. Brought up in: servo/servo#7776 (comment) Source-Repo: https://github.com/servo/servo Source-Revision: 520c907742afbb94085c6b5e62156a5457530010 UltraBlame original commit: ce33507715eacf6a421095c1da08d2c4326d34ef
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…ncatExt::join (from frewsxcv:consistent-str-join); r=mbrubeck Prior to this commit, `str_join` would skip empty items at the start of the `Iterator` until it found a non-empty item. This contradicts `SliceConcatExt::join` which doesn't skip anything. Brought up in: servo/servo#7776 (comment) Source-Repo: https://github.com/servo/servo Source-Revision: 520c907742afbb94085c6b5e62156a5457530010 UltraBlame original commit: ce33507715eacf6a421095c1da08d2c4326d34ef
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…ncatExt::join (from frewsxcv:consistent-str-join); r=mbrubeck Prior to this commit, `str_join` would skip empty items at the start of the `Iterator` until it found a non-empty item. This contradicts `SliceConcatExt::join` which doesn't skip anything. Brought up in: servo/servo#7776 (comment) Source-Repo: https://github.com/servo/servo Source-Revision: 520c907742afbb94085c6b5e62156a5457530010 UltraBlame original commit: ce33507715eacf6a421095c1da08d2c4326d34ef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
frewsxcv commentedSep 28, 2015