Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for caseless group name matching in HTML input elements #7777

Merged
merged 1 commit into from Oct 2, 2015
Merged

Add support for caseless group name matching in HTML input elements #7777

merged 1 commit into from Oct 2, 2015

Conversation

@KiChjang
Copy link
Member

KiChjang commented Sep 29, 2015

Fixes #7749

Review on Reviewable
@KiChjang
Copy link
Member Author

KiChjang commented Sep 29, 2015

Aaaaaaaaaaaaaaand I just hit the lucky jackpot with the PR number of 7777!
@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 29, 2015

No tests that cover this?
@KiChjang
Copy link
Member Author

KiChjang commented Sep 29, 2015

Remind me again where do I include them?
@bors-servo
Copy link
Contributor

bors-servo commented Sep 29, 2015

☔ The latest upstream changes (presumably #7786) made this pull request unmergeable. Please resolve the merge conflicts.
@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 30, 2015

@KiChjang There may be existing tests that cover this in the WPT test suit, which you can run with the ./mach test-wpt command. Warning: This takes a very very long time. You might want to search through the tests and only run specific ones that look likely to be affected, and/or use a release build and the --release argument. If this doesn't cause any existing tests to pass, then you could add your own test. For more info see:
@KiChjang KiChjang force-pushed the KiChjang:caseless-group-name-match branch from b1b67d0 to 256fdbd Sep 30, 2015
@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 30, 2015

r? @jdm
@KiChjang
Copy link
Member Author

KiChjang commented Sep 30, 2015

There's a test that specifically tests for the name attribute for radio buttons at html/semantics/forms/the-input-element/radio-groupname-case.html. It's currently passing 6 of the 7 tests.
@jdm
Copy link
Member

jdm commented Oct 1, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2015

📌 Commit 316cc2e has been approved by jdm
@jdm jdm removed the S-needs-tests label Oct 1, 2015
@jdm jdm mentioned this pull request Oct 1, 2015
Open
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2015

⌛ Testing commit 316cc2e with merge 7e4add9...
bors-servo pushed a commit that referenced this pull request Oct 1, 2015
bors-servo
Auto merge of #7777 - KiChjang:caseless-group-name-match, r=jdm
7e4add9 
Add support for caseless group name matching in HTML input elements

Fixes #7749

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7777)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2015

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Oct 1, 2015 


/html/semantics/forms/the-input-element/radio.html
--------------------------------------------------
PASS expected FAIL radio inputs with name attributes groüp2 and groÜp2 belong to the same radio button group
@jdm
Copy link
Member

jdm commented Oct 2, 2015

Could you squash all these commits together?
@jdm jdm added the S-needs-squash label Oct 2, 2015
@jdm jdm removed the S-awaiting-review label Oct 2, 2015
@KiChjang KiChjang force-pushed the KiChjang:caseless-group-name-match branch from 7d897f8 to 5c9a25d Oct 2, 2015
@KiChjang
Add support for caseless group name matching in HTML input elements
Loading status checks…
5c9a25d
@jdm
Copy link
Member

jdm commented Oct 2, 2015

@bors-servo: r+
Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2015

📌 Commit 5c9a25d has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2015

⌛ Testing commit 5c9a25d with merge 2a3ad21...
bors-servo pushed a commit that referenced this pull request Oct 2, 2015
bors-servo
Auto merge of #7777 - KiChjang:caseless-group-name-match, r=jdm
2a3ad21 
Add support for caseless group name matching in HTML input elements

Fixes #7749

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7777)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2015

💔 Test failed - mac-dev-ref-unit
@mbrubeck
Copy link
Contributor

mbrubeck commented Oct 2, 2015

@bors-servo retry

#7785
bors-servo pushed a commit that referenced this pull request Oct 2, 2015
bors-servo
Auto merge of #7777 - KiChjang:caseless-group-name-match, r=jdm
Loading status checks…
e9842b7 
Add support for caseless group name matching in HTML input elements

Fixes #7749

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7777)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2015

⌛ Testing commit 5c9a25d with merge e9842b7...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 5c9a25d into servo:master Oct 2, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@KiChjang KiChjang deleted the KiChjang:caseless-group-name-match branch Dec 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@KiChjang @Ms2ger @bors-servo @mbrubeck @jdm @highfive
You can’t perform that action at this time.