Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Au type into separate crate, with minimal dependencies. #7795

Merged
merged 1 commit into from Sep 30, 2015
Merged

Split Au type into separate crate, with minimal dependencies. #7795

merged 1 commit into from Sep 30, 2015

Conversation

@glennw
Copy link
Member

glennw commented Sep 30, 2015

Review on Reviewable
@highfive
Copy link

highfive commented Sep 30, 2015

warning Warning warning

  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
@glennw
Copy link
Member Author

glennw commented Sep 30, 2015

@metajack or @SimonSapin r?

Instead of making cssparser depend on app_units, Simon suggested implementing to_css for Au in the style crate.

It works and it seems OK to me, but if anyone has strong objections to this change - let me know - and I'll find a different way to achieve it.
@bors-servo
Copy link
Contributor

bors-servo commented Sep 30, 2015

☔ The latest upstream changes (presumably #7423) made this pull request unmergeable. Please resolve the merge conflicts.
@SimonSapin
Copy link
Member

SimonSapin commented Sep 30, 2015

r=me with a rebase
@gw3583
Split Au type into separate crate, with minimal dependencies.
Loading status checks…
339a3f8
@glennw glennw force-pushed the glennw:app-units-crate branch from 24a3015 to 339a3f8 Sep 30, 2015
@glennw
Copy link
Member Author

glennw commented Sep 30, 2015

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Sep 30, 2015

📌 Commit 339a3f8 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Sep 30, 2015

⌛ Testing commit 339a3f8 with merge 35888e5...
bors-servo pushed a commit that referenced this pull request Sep 30, 2015
bors-servo
Auto merge of #7795 - glennw:app-units-crate, r=SimonSapin
Loading status checks…
35888e5 
Split Au type into separate crate, with minimal dependencies.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7795)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 30, 2015

💔 Test failed - mac-dev-ref-unit
@glennw
Copy link
Member Author

glennw commented Sep 30, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 30, 2015

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only mac-dev-ref-unit...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 30, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 339a3f8 into servo:master Sep 30, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@glennw glennw deleted the glennw:app-units-crate branch Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
A-content/css A-gfx/uncategorized I-refactor
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@glennw @highfive @bors-servo @SimonSapin @mbrubeck @gw3583
You can’t perform that action at this time.