Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code from net_traits. #7798

Merged
merged 1 commit into from
Sep 30, 2015
Merged

Remove dead code from net_traits. #7798

merged 1 commit into from
Sep 30, 2015

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Sep 30, 2015

It was added in commit ecf02a3.

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 30, 2015
@jdm
Copy link
Member

jdm commented Sep 30, 2015

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 49936b6 has been approved by jdm

@bors-servo
Copy link
Contributor

⌛ Testing commit 49936b6 with merge f289448...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 30, 2015
bors-servo pushed a commit that referenced this pull request Sep 30, 2015
Auto merge of #7798 - Ms2ger:dead, r=jdm
f289448 
Remove dead code from net_traits.

It was added in commit ecf02a3.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7798)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 30, 2015
@jdm
Copy link
Member

jdm commented Sep 30, 2015

@bors-servo: retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 49936b6 with merge 61be58a...

bors-servo pushed a commit that referenced this pull request Sep 30, 2015
Auto merge of #7798 - Ms2ger:dead, r=jdm
61be58a 
Remove dead code from net_traits.

It was added in commit ecf02a3.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7798)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 30, 2015
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit 49936b6 into servo:master Sep 30, 2015
@Ms2ger Ms2ger deleted the dead branch October 6, 2015 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ms2ger @jdm @bors-servo @highfive