Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle zero-sized source surfaces properly, and upgrade `ipc-channel` to incorporate the fix for zero-sized shmem on Mac. #7802

Merged
merged 1 commit into from Oct 1, 2015

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Sep 30, 2015

Depends on servo/rust-azure#201 and pcwalton/ipc-channel#10.

Closes #7422.

r? @mbrubeck (don't r+ until the upstream dependencies have landed)

cc @jdm

Review on Reviewable

@mbrubeck
Copy link
Contributor

mbrubeck commented Sep 30, 2015

-S-awaiting-review

r=mbrubeck


Reviewed 3 of 3 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from the review on Reviewable.io

@mbrubeck mbrubeck self-assigned this Sep 30, 2015
@pcwalton pcwalton force-pushed the pcwalton:zero-size-source-surfaces branch from 4658b3d to 24fdc8a Oct 1, 2015
@pcwalton
Copy link
Contributor Author

pcwalton commented Oct 1, 2015

@bors-servo: r=mbrubeck

@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2015

📌 Commit 24fdc8a has been approved by mbrubeck

@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2015

Testing commit 24fdc8a with merge e2048d5...

bors-servo pushed a commit that referenced this pull request Oct 1, 2015
Handle zero-sized source surfaces properly, and upgrade `ipc-channel` to incorporate the fix for zero-sized shmem on Mac.

Depends on servo/rust-azure#201 and pcwalton/ipc-channel#10.

Closes #7422.

r? @mbrubeck (don't r+ until the upstream dependencies have landed)

cc @jdm

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7802)
<!-- Reviewable:end -->
incorporate the fix for zero-sized shmem on Mac.

Depends on servo/rust-azure#201 and pcwalton/ipc-channel#10.

Closes #7422.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2015

@bors-servo bors-servo merged commit 24fdc8a into servo:master Oct 1, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@pcwalton pcwalton deleted the pcwalton:zero-size-source-surfaces branch Oct 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.