Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes for reftest command-line handling #7815
Merged
Conversation
|
@bors-servo r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Oct 1, 2015
Fixes for reftest command-line handling r? @SimonSapin * Allow reftest harness to take 0 or more testname arguments. * Change `mach test-ref` parameter from `--name` to `--include`. This is consistent with other test suites, and also fixes a bug in `mach test` caused by a conflicting keyword parameter in `Registrar.dispatch`. * Allow `mach test-ref` to take any number of `include` arguments. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7815) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
bors-servo
pushed a commit
that referenced
this pull request
Oct 1, 2015
Fixes for reftest command-line handling r? @SimonSapin * Allow reftest harness to take 0 or more testname arguments. * Change `mach test-ref` parameter from `--name` to `--include`. This is consistent with other test suites, and also fixes a bug in `mach test` caused by a conflicting keyword parameter in `Registrar.dispatch`. * Allow `mach test-ref` to take any number of `include` arguments. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7815) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
bors-servo
pushed a commit
that referenced
this pull request
Oct 1, 2015
Fixes for reftest command-line handling r? @SimonSapin * Allow reftest harness to take 0 or more testname arguments. * Change `mach test-ref` parameter from `--name` to `--include`. This is consistent with other test suites, and also fixes a bug in `mach test` caused by a conflicting keyword parameter in `Registrar.dispatch`. * Allow `mach test-ref` to take any number of `include` arguments. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7815) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedOct 1, 2015
r? @SimonSapin
mach test-refparameter from--nameto--include. This is consistent with other test suites, and also fixes a bug inmach testcaused by a conflicting keyword parameter inRegistrar.dispatch.mach test-refto take any number ofincludearguments.