Implement a quota of 5MB per origin for localstorage and sessionstorage

[iawaknahc]

PR for #6739

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Ms2ger (or someone else) soon.

[iawaknahc]

r? @Ms2ger

[jdm]

This looks really good! Just a couple subtleties about counting bytes and some changes for readability before we can merge!
-S-awaiting-review +S-needs-code-changes

---

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, 7 unresolved discussions, all commit checks successful.

---

^{components/net/storage_task.rs, line 43 [r1] (raw file):}
I'm inclined to make this a global const value rather than a member.

---

^{components/net/storage_task.rs, line 112 [r1] (raw file):}
We should update this description with the new behaviour.

---

^{components/net/storage_task.rs, line 128 [r1] (raw file):}
This doesn't seem necessary.

---

^{components/net/storage_task.rs, line 137 [r1] (raw file):}
Can we use this instead?

let mut new_total_size = current_total_size + value.len();
if let Some(old_value) = entry.get(&name) {
     new_total_size -= old_value.len();
} else {
    new_total_size += name.len();
};

Also, we should be using .as_bytes().len() instead of .len() for all of these calculations, to account for multibyte characters.

---

^{components/net/storage_task.rs, line 147 [r1] (raw file):}
We don't need to repeat the total calculations again, do we? Can't we use the value we calculated above?

---

^{components/net/storage_task.rs, line 182 [r1] (raw file):}
Same comment about byte length.

---

^{components/net_traits/storage_task.rs, line 28 [r1] (raw file):}
I'm inclined to make this a Result<(bool, Option<DOMString>), ()> instead.

---

Comments from the review on Reviewable.io

[jdm]

Great! Go ahead and squash these commits together, please!
-S-awaiting-review +S-needs-squash

---

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

Comments from the review on Reviewable.io

[jdm]

Just need to rebase to resolve the merge conflicts now :)

[jdm]

/build/components/net/storage_task.rs:121:54: 121:60 error: no method named `keys` found for type `&(usize, collections::btree::map::BTreeMap<collections::string::String, collections::string::String>)` in the current scope

/build/components/net/storage_task.rs:121                        .map_or(vec![], |entry| entry.keys().cloned().collect());

                                                                                               ^~~~~~

[iawaknahc]

Sorry about that.

[jdm]

No problem! It's what travis is there to protect against :)

[jdm]

@bors-servo: r+

[bors-servo]

📌 Commit fb45b0e has been approved by jdm

[bors-servo]

⌛ Testing commit fb45b0e with merge a562f6e...

[bors-servo]

💔 Test failed - linux-dev

[jdm]

@bors-servo: retry

• #7931

[bors-servo]

⚡ Previous build results for android, gonk, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-dev...

[bors-servo]

💔 Test failed - linux-dev

[jdm]

@bors-servo: retry

• #7931

[bors-servo]

⌛ Testing commit fb45b0e with merge da27d07...

[bors-servo]

💔 Test failed - mac-rel-wpt

[jdm]

@bors-servo: retry

• #7731

[bors-servo]

⌛ Testing commit fb45b0e with merge 06e0447...

[bors-servo]

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt