Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement <body>'s "text" attribute #7841

Merged
merged 1 commit into from Oct 9, 2015
Merged

Implement <body>'s "text" attribute #7841

merged 1 commit into from Oct 9, 2015

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Oct 3, 2015

Review on Reviewable
...quirements-for-implementations/other-elements-attributes-and-apis/document-color-02.html.ini
@@ -12,3 +12,6 @@
[document: fg/bg/link/vlink/alink-color 5]
expected: FAIL

[document: fg/bg/link/vlink/alink-color]

This comment has been minimized.

Sign in to view
Copy link
@frewsxcv

frewsxcv Oct 3, 2015

Author Member

These now fail because both vlink and text attributes were not implemented, so undefined === undefined. Now that text is implemented, they no longer are equal since "" !== undefined
tests/wpt/metadata/html/rendering/non-replaced-elements/the-page/body_text_00ffff.xhtml.ini Outdated
@@ -2,4 +2,3 @@
type: reftest
reftype: ==
refurl: /html/rendering/non-replaced-elements/the-page/body_text_00ffff-ref.html
expected: FAIL

This comment has been minimized.

Sign in to view
Copy link
@eefriedman

eefriedman Oct 3, 2015

Contributor

Can you just delete the whole ini file?

This comment has been minimized.

Sign in to view
Copy link
@frewsxcv

frewsxcv Oct 3, 2015

Author Member

Good call. Removed in the latest force push.
@frewsxcv frewsxcv force-pushed the frewsxcv:htmlbodyelement-text branch from 20dbb61 to 9591931 Oct 3, 2015
@nox nox self-assigned this Oct 5, 2015
@nox
Copy link
Member

nox commented Oct 5, 2015

-S-awaiting-review +S-needs-code-changes

Reviewed 9 of 9 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

components/script/dom/htmlbodyelement.rs, line 39 [r1] (raw file):
As in #7683, we should introduce a new AttrValue variant. This can be reused for background_color too in that very element.

Comments from the review on Reviewable.io
@frewsxcv frewsxcv force-pushed the frewsxcv:htmlbodyelement-text branch from 9591931 to aa171ae Oct 5, 2015
@frewsxcv frewsxcv force-pushed the frewsxcv:htmlbodyelement-text branch from aa171ae to d4ed754 Oct 5, 2015
@frewsxcv
Copy link
Member Author

frewsxcv commented Oct 5, 2015

Comment has been addressed
@nox
Copy link
Member

nox commented Oct 5, 2015

@bors-servo r+

Please file a follow-up for the background_color field (or just an issue for all of them, while we are at it).

Reviewed 4 of 4 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Oct 5, 2015

📌 Commit d4ed754 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Oct 5, 2015

⌛ Testing commit d4ed754 with merge 4413ab0...
bors-servo pushed a commit that referenced this pull request Oct 5, 2015
bors-servo
Auto merge of #7841 - frewsxcv:htmlbodyelement-text, r=nox
4413ab0 
Implement <body>'s "text" attribute



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7841)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 5, 2015

💔 Test failed - linux-rel
@frewsxcv
Copy link
Member Author

frewsxcv commented Oct 5, 2015

That's a legit fail. I'll look into it later.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 5, 2015

☔ The latest upstream changes (presumably #7867) made this pull request unmergeable. Please resolve the merge conflicts.
@frewsxcv frewsxcv force-pushed the frewsxcv:htmlbodyelement-text branch from d4ed754 to 7e124b5 Oct 6, 2015
@highfive highfive removed the S-tests-failed label Oct 6, 2015
@frewsxcv frewsxcv force-pushed the frewsxcv:htmlbodyelement-text branch from 120c33d to 64f4835 Oct 8, 2015
@frewsxcv
Copy link
Member Author

frewsxcv commented Oct 8, 2015

Comments have been addressed
@nox
Copy link
Member

nox commented Oct 8, 2015

@bors-servo r+

Reviewed 2 of 2 files at r5.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Oct 8, 2015

📌 Commit 64f4835 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Oct 8, 2015

⌛ Testing commit 64f4835 with merge e7b97ba...
bors-servo pushed a commit that referenced this pull request Oct 8, 2015
bors-servo
Auto merge of #7841 - frewsxcv:htmlbodyelement-text, r=nox
e7b97ba 
Implement <body>'s "text" attribute



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7841)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 8, 2015

💔 Test failed - linux-dev
@nox
Copy link
Member

nox commented Oct 8, 2015

#7931
@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 9, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2015

⌛ Testing commit 64f4835 with merge 1029feb...
bors-servo pushed a commit that referenced this pull request Oct 9, 2015
bors-servo
Auto merge of #7841 - frewsxcv:htmlbodyelement-text, r=nox
Loading status checks…
1029feb 
Implement <body>'s "text" attribute



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7841)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 64f4835 into servo:master Oct 9, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the frewsxcv:htmlbodyelement-text branch Oct 9, 2015
frewsxcv added a commit to frewsxcv/servo that referenced this pull request Nov 28, 2015
@frewsxcv
Implement attribute 'fgColor' on 'document'
60b1489 
The 'text' attribute was implemented on '<body>' in servo#7841
@frewsxcv frewsxcv mentioned this pull request Nov 28, 2015
Merged
frewsxcv added a commit to frewsxcv/servo that referenced this pull request Nov 30, 2015
@frewsxcv
Implement attribute 'fgColor' on 'document'
c363f51 
The 'text' attribute was implemented on '<body>' in servo#7841
frewsxcv added a commit to frewsxcv/servo that referenced this pull request Nov 30, 2015
@frewsxcv
Implement attribute 'fgColor' on 'document'
98e9aa8 
The 'text' attribute was implemented on '<body>' in servo#7841
frewsxcv added a commit to frewsxcv/servo that referenced this pull request Nov 30, 2015
@frewsxcv
Implement attribute 'fgColor' on 'document'
d3e5e1e 
The 'text' attribute was implemented on '<body>' in servo#7841
frewsxcv added a commit to frewsxcv/servo that referenced this pull request Nov 30, 2015
@frewsxcv
Implement attribute 'fgColor' on 'document'
3202631 
The 'text' attribute was implemented on '<body>' in servo#7841
bors-servo added a commit that referenced this pull request Dec 1, 2015
@bors-servo
Auto merge of #8714 - frewsxcv:body-fgcolor, r=Ms2ger
Loading status checks…
6510834 
Implement attribute 'fgColor' on 'document'

The 'text' attribute was implemented on `<body>` in #7841

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8714)
<!-- Reviewable:end -->
asajeffrey added a commit to asajeffrey/servo that referenced this pull request Dec 2, 2015
@frewsxcv @asajeffrey
Implement attribute 'fgColor' on 'document'
17479b7 
The 'text' attribute was implemented on '<body>' in servo#7841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
A-content/css A-content/dom S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@frewsxcv @nox @bors-servo @Ms2ger @eefriedman @highfive
You can’t perform that action at this time.