Add HTMLFormControlsCollection interface

[frewsxcv]

https://html.spec.whatwg.org/multipage/#htmlformcontrolscollection

[Manishearth]

LGTM overall. Minor nits.

---

Review status: 0 of 8 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

---

^{components/script/dom/htmlcollection.rs, line 25 [r1] (raw file):}
Would prefer if these were private with a constructor and #[privatize]. Too easy to accidentally extract a JS<T> otherwise

---

^{components/script/dom/htmlformcontrolscollection.rs, line 24 [r1] (raw file):}
Spec link: https://html.spec.whatwg.org/multipage/forms.html#category-listed

---

^{components/script/dom/htmlformcontrolscollection.rs, line 57 [r1] (raw file):}
What's this for?

---

Comments from the review on Reviewable.io

[Manishearth]

Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

---

Comments from the review on Reviewable.io

[Manishearth]

Review status: all files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.

---

^{components/script/dom/htmlformcontrolscollection.rs, line 59 [r1] (raw file):}
@nox: Any reason why this needs to be explicitly implemented (given that in can inherit)?

We haven't uncommented the explicit overriding getter in the webidl. (I think we should file a followup for that though)

---

Comments from the review on Reviewable.io

[nox]

Review status: all files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.

---

^{components/script/dom/htmlformcontrolscollection.rs, line 59 [r1] (raw file):}
You mean this? :) #5875

---

Comments from the review on Reviewable.io

[frewsxcv]

^{components/script/dom/htmlformcontrolscollection.rs, line 24 [r1] (raw file):}
I have it linked a few lines abvoe

---

Comments from the review on Reviewable.io

[frewsxcv]

^{components/script/dom/htmlformcontrolscollection.rs, line 57 [r1] (raw file):}
The tidy checker makes sure all methods in *Methods traits have spec links. This comment allows that behavior to be overridden. I didn't link to the spec for these methods here because these are all inherited by the parent interface

---

Comments from the review on Reviewable.io

[frewsxcv]

@bors-servo r=Manishearth

[bors-servo]

📌 Commit 17124ee has been approved by Manishearth

[bors-servo]

⌛ Testing commit 17124ee with merge fd182a3...

[bors-servo]

💔 Test failed - mac-rel-wpt

[Manishearth]

You need to update /_mozilla/mozilla/interfaces.html

[frewsxcv]

/cc @jdm @Ms2ger

[Manishearth]

That's fine, it's a window-exposed DOM type (try it in Firefox). Make sure you add it to the DOM interface array, not the ECMA array.

[frewsxcv]

Yep, it's added

[Ms2ger]

There's ongoing discussion about this: whatwg/html#200

[bors-servo]

☔ The latest upstream changes (presumably #7960) made this pull request unmergeable. Please resolve the merge conflicts.

[frewsxcv]

#8566