Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style <select multiple> appropriately. #7847

Merged
merged 1 commit into from Oct 4, 2015
Merged

Style <select multiple> appropriately. #7847

merged 1 commit into from Oct 4, 2015
+32 −4

Conversation

@jdm
Copy link
Member

jdm commented Oct 4, 2015

screen shot 2015-10-04 at 2 33 36 pm

Review on Reviewable
@jdm
Style <select multiple> appropriately.
Loading status checks…
9ed0ae4
@jdm jdm force-pushed the jdm:selectstyling branch from 87b0537 to 9ed0ae4 Oct 4, 2015
@Manishearth
Copy link
Member

Manishearth commented Oct 4, 2015

Reviewed 2 of 2 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io
@jdm jdm mentioned this pull request Oct 4, 2015
Open
@Manishearth
Copy link
Member

Manishearth commented Oct 4, 2015

@bors-servo r+

Looks strange on Linux since Linux the focus color is orangey instead of blue, but we don't do OS specific theming yet so I'm fine with that.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2015

📌 Commit 9ed0ae4 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2015

⌛ Testing commit 9ed0ae4 with merge 460f067...
bors-servo pushed a commit that referenced this pull request Oct 4, 2015
bors-servo
Auto merge of #7847 - jdm:selectstyling, r=Manishearth
Loading status checks…
460f067 
Style <select multiple> appropriately.

<img width="216" alt="screen shot 2015-10-04 at 2 33 36 pm" src="https://cloud.githubusercontent.com/assets/27658/10269411/ec1b5bce-6aa4-11e5-8ce8-0f22425ea3d4.png">

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7847)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2015

💔 Test failed - linux-rel
@jdm
Copy link
Member Author

jdm commented Oct 4, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2015

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 4, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 9ed0ae4 into servo:master Oct 4, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @Manishearth @bors-servo @SimonSapin @highfive
You can’t perform that action at this time.