Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMove some methods from RawLayoutElementHelpers to LayoutElementHelpers. #7867
Conversation
This is part of a long-term plan to ensure layout never has access to unwrapped pointers to DOM objects. The remaining methods on the RawLayoutElementHelpers trait are harder to move, because of the lifetimes in their signatures.
highfive
commented
Oct 5, 2015
|
|
|
@bors-servo r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Oct 5, 2015
Move some methods from RawLayoutElementHelpers to LayoutElementHelpers. This is part of a long-term plan to ensure layout never has access to unwrapped pointers to DOM objects. The remaining methods on the RawLayoutElementHelpers trait are harder to move, because of the lifetimes in their signatures. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7867) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Oct 5, 2015
Move some methods from RawLayoutElementHelpers to LayoutElementHelpers. This is part of a long-term plan to ensure layout never has access to unwrapped pointers to DOM objects. The remaining methods on the RawLayoutElementHelpers trait are harder to move, because of the lifetimes in their signatures. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7867) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
|
|
|
|
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Oct 19, 2015
Fixes servo#7867 (and probably several other iframe bugs). When collecting layers for children of a pipeline, pass through the current subpage pipeline recursively. This prevents descendany layers (such as scroll layers) from being collected and re-created on the subsequent paint.
bors-servo
pushed a commit
that referenced
this pull request
Oct 19, 2015
Fix iframes flickering on mouse move. Fixes #7867 (and probably several other iframe bugs). When collecting layers for children of a pipeline, pass through the current subpage pipeline recursively. This prevents descendant layers (such as scroll layers) from being collected and re-created on the subsequent paint. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8089) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this pull request
Oct 19, 2015
Fix iframes flickering on mouse move. Fixes #7867 (and probably several other iframe bugs). When collecting layers for children of a pipeline, pass through the current subpage pipeline recursively. This prevents descendant layers (such as scroll layers) from being collected and re-created on the subsequent paint. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8089) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedOct 5, 2015
This is part of a long-term plan to ensure layout never has access to
unwrapped pointers to DOM objects. The remaining methods on the
RawLayoutElementHelpers trait are harder to move, because of the lifetimes in
their signatures.