Skip to content

Comments

remove data field from websockets#7880

Merged
bors-servo merged 1 commit intoservo:masterfrom
r-52:websockets-data-field
Oct 5, 2015
Merged

remove data field from websockets#7880
bors-servo merged 1 commit intoservo:masterfrom
r-52:websockets-data-field

Conversation

@r-52
Copy link
Contributor

@r-52 r-52 commented Oct 5, 2015

The data field is currently not used (no reads/ writes). This commit
removes this temp. field.

Ref.-Issue: #7859

Review on Reviewable

The data field is currently not used (no reads/ writes). This commit
removes this field.

Ref.-Issue: #7859
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 5, 2015
@highfive
Copy link

highfive commented Oct 5, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon.

@jdm
Copy link
Member

jdm commented Oct 5, 2015

@bors-servo: r+
Thanks for doing this cleanup!

@bors-servo
Copy link
Contributor

📌 Commit 1f82e51 has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 5, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit 1f82e51 with merge 94816bb...

bors-servo pushed a commit that referenced this pull request Oct 5, 2015
remove data field from websockets

The data field is currently not used (no reads/ writes). This commit
removes this temp. field.

Ref.-Issue: #7859

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7880)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 5, 2015
@jdm
Copy link
Member

jdm commented Oct 5, 2015

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-rel-wpt are reusable. Rebuilding only mac-dev-ref-unit, mac-rel-css...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit 1f82e51 into servo:master Oct 5, 2015
@SimonSapin SimonSapin removed the S-tests-failed The changes caused existing tests to fail. label Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants