Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove data field from websockets #7880

Merged
merged 1 commit into from Oct 5, 2015
Merged

remove data field from websockets #7880

merged 1 commit into from Oct 5, 2015

Conversation

@r-52
Copy link
Contributor

r-52 commented Oct 5, 2015

The data field is currently not used (no reads/ writes). This commit
removes this temp. field.

Ref.-Issue: #7859

Review on Reviewable

The data field is currently not used (no reads/ writes). This commit
removes this field.

Ref.-Issue: #7859
@highfive
Copy link

highfive commented Oct 5, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon.

@jdm
Copy link
Member

jdm commented Oct 5, 2015

@bors-servo: r+
Thanks for doing this cleanup!

@bors-servo
Copy link
Contributor

bors-servo commented Oct 5, 2015

📌 Commit 1f82e51 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Oct 5, 2015

Testing commit 1f82e51 with merge 94816bb...

bors-servo pushed a commit that referenced this pull request Oct 5, 2015
remove data field from websockets

The data field is currently not used (no reads/ writes). This commit
removes this temp. field.

Ref.-Issue: #7859

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7880)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 5, 2015

💔 Test failed - mac-rel-css

@jdm
Copy link
Member

jdm commented Oct 5, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Oct 5, 2015

Previous build results for android, gonk, linux-dev, linux-rel, mac-rel-wpt are reusable. Rebuilding only mac-dev-ref-unit, mac-rel-css...

@bors-servo
Copy link
Contributor

bors-servo commented Oct 5, 2015

@bors-servo bors-servo merged commit 1f82e51 into servo:master Oct 5, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.