remove data field from websockets#7880
Merged
bors-servo merged 1 commit intoservo:masterfrom Oct 5, 2015
r-52:websockets-data-field
Merged
remove data field from websockets#7880bors-servo merged 1 commit intoservo:masterfrom r-52:websockets-data-field
bors-servo merged 1 commit intoservo:masterfrom
r-52:websockets-data-field
Conversation
The data field is currently not used (no reads/ writes). This commit removes this field. Ref.-Issue: #7859
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon. |
Member
|
@bors-servo: r+ |
Contributor
|
📌 Commit 1f82e51 has been approved by |
highfive
added
S-awaiting-merge
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Oct 5, 2015
remove data field from websockets The data field is currently not used (no reads/ writes). This commit removes this temp. field. Ref.-Issue: #7859 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7880) <!-- Reviewable:end -->
Contributor
|
💔 Test failed - mac-rel-css |
highfive
added
S-tests-failed
Member
Contributor
|
⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-rel-wpt are reusable. Rebuilding only mac-dev-ref-unit, mac-rel-css... |
Contributor
|
☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data field is currently not used (no reads/ writes). This commit
removes this temp. field.
Ref.-Issue: #7859