Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw shadows after the background. #7883

Merged
merged 1 commit into from Oct 7, 2015
Merged

Draw shadows after the background. #7883

merged 1 commit into from Oct 7, 2015
+60 −4

Conversation

@notriddle
Copy link
Contributor

notriddle commented Oct 5, 2015

Fixes #7872

Review on Reviewable
@notriddle
Draw shadows after the background.
Loading status checks…
75a08cc 
Fixes #7872
@pcwalton
Copy link
Contributor

pcwalton commented Oct 5, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 5, 2015

📌 Commit 75a08cc has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Oct 5, 2015

⌛ Testing commit 75a08cc with merge 1cbc23c...
bors-servo pushed a commit that referenced this pull request Oct 5, 2015
bors-servo
Auto merge of #7883 - notriddle:master, r=pcwalton
1cbc23c 
Draw shadows after the background.

Fixes #7872

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7883)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 5, 2015

💔 Test failed - mac-rel-wpt
@notriddle
Copy link
Contributor Author

notriddle commented Oct 5, 2015

That timeout doesn't occur when I run the test myself.
@jdm
Copy link
Member

jdm commented Oct 6, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 6, 2015

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 6, 2015

💔 Test failed - mac-rel-wpt
@nox
Copy link
Member

nox commented Oct 6, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 6, 2015

⌛ Testing commit 75a08cc with merge b05e185...
bors-servo pushed a commit that referenced this pull request Oct 6, 2015
bors-servo
Auto merge of #7883 - notriddle:master, r=pcwalton
b05e185 
Draw shadows after the background.

Fixes #7872

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7883)
<!-- Reviewable:end -->
@Ms2ger Ms2ger closed this Oct 6, 2015
@Ms2ger Ms2ger reopened this Oct 6, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Oct 6, 2015

⌛ Testing commit 75a08cc with merge 2ffd669...
bors-servo pushed a commit that referenced this pull request Oct 6, 2015
bors-servo
Auto merge of #7883 - notriddle:master, r=pcwalton
2ffd669 
Draw shadows after the background.

Fixes #7872

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7883)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 6, 2015

💔 Test failed - mac-dev-ref-unit
@bors-servo
Copy link
Contributor

bors-servo commented Oct 6, 2015

💔 Test failed - mac-dev-ref-unit
@jdm
Copy link
Member

jdm commented Oct 6, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 6, 2015

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-rel-css are reusable. Rebuilding only mac-dev-ref-unit, mac-rel-wpt...
@jdm
Copy link
Member

jdm commented Oct 6, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 6, 2015

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-rel-css are reusable. Rebuilding only mac-dev-ref-unit, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 6, 2015

💔 Test failed - mac-dev-ref-unit
@jdm
Copy link
Member

jdm commented Oct 7, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 7, 2015

⌛ Testing commit 75a08cc with merge 86fe5cf...
bors-servo pushed a commit that referenced this pull request Oct 7, 2015
bors-servo
Auto merge of #7883 - notriddle:master, r=pcwalton
86fe5cf 
Draw shadows after the background.

Fixes #7872

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7883)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 7, 2015

💔 Test failed - mac-dev-ref-unit
@jdm
Copy link
Member

jdm commented Oct 7, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 7, 2015

⚡ Previous build results for android, gonk, linux-dev are reusable. Rebuilding only linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 7, 2015

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Oct 7, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 7, 2015

⌛ Testing commit 75a08cc with merge 409fbaf...
bors-servo pushed a commit that referenced this pull request Oct 7, 2015
bors-servo
Auto merge of #7883 - notriddle:master, r=pcwalton
Loading status checks…
409fbaf 
Draw shadows after the background.

Fixes #7872

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7883)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 7, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 75a08cc into servo:master Oct 7, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@notriddle @pcwalton @bors-servo @jdm @nox @Ms2ger @highfive
You can’t perform that action at this time.