Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw shadows after the background. #7883

Merged
merged 1 commit into from Oct 7, 2015
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -966,14 +966,14 @@ impl FragmentDisplayListBuilding for Fragment {
// Add shadows, background, borders, and outlines, if applicable.
if let Some(ref inline_context) = self.inline_context {
for node in inline_context.nodes.iter().rev() {
self.build_display_list_for_box_shadow_if_applicable(
self.build_display_list_for_background_if_applicable(
&*node.style,
display_list,
layout_context,
level,
&stacking_relative_border_box,
&clip);
self.build_display_list_for_background_if_applicable(
self.build_display_list_for_box_shadow_if_applicable(
&*node.style,
display_list,
layout_context,
@@ -1003,13 +1003,13 @@ impl FragmentDisplayListBuilding for Fragment {
}

if !self.is_scanned_text_fragment() {
self.build_display_list_for_box_shadow_if_applicable(&*self.style,
self.build_display_list_for_background_if_applicable(&*self.style,
display_list,
layout_context,
level,
&stacking_relative_border_box,
&clip);
self.build_display_list_for_background_if_applicable(&*self.style,
self.build_display_list_for_box_shadow_if_applicable(&*self.style,
display_list,
layout_context,
level,
@@ -77,10 +77,12 @@ flaky_cpu == append_style_a.html append_style_b.html
== border_spacing_fixed_layout_a.html border_spacing_ref.html
== border_style_none_a.html border_style_none_b.html
== borders_a.html borders_b.html
== box_shadow_bg.html box_shadow_bg_ref.html
!= box_shadow_blur_a.html box_shadow_blur_ref.html
== box_shadow_border_box_a.html box_shadow_border_box_ref.html
== box_shadow_default_color_a.html box_shadow_default_color_ref.html
== box_shadow_inset_a.html box_shadow_inset_ref.html
== box_shadow_inset_bg.html box_shadow_inset_bg_ref.html
== box_shadow_inset_parsing_a.html box_shadow_inset_parsing_ref.html
== box_shadow_paint_order_a.html box_shadow_paint_order_ref.html
== box_shadow_spread_a.html box_shadow_spread_ref.html
@@ -0,0 +1,11 @@
<div></div>

<style>
div {
width: 100px;
height: 100px;
box-shadow: 0 20px 0 0 red;
background-color: rgba(0,0,0,0.7);
}
</style>

@@ -0,0 +1,16 @@
<div></div><span></span>

<style>
div {
width: 100px;
height: 100px;
background-color: rgba(0,0,0,0.7);
}
span {
background-color: red;
width: 100px;
height: 20px;
display: block;
}
</style>

@@ -0,0 +1,11 @@
<div></div>

<style>
div {
width: 100px;
height: 100px;
box-shadow: inset 0 20px 0 0 red;
background-color: rgba(0,0,0,0.7);
}
</style>

@@ -0,0 +1,16 @@
<div><span></span></div>

<style>
div {
width: 100px;
height: 100px;
background-color: rgba(0,0,0,0.7);
}
span {
background-color: red;
width: 100px;
height: 20px;
display: block;
}
</style>

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.