Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uplayout: Add a field in the display list for simple border radii on box shadows. #7896
Conversation
highfive
commented
Oct 6, 2015
|
|
shadows. Only supported in WebRender (with my upcoming PR) for now.
|
@bors-servo r+ |
|
|
pcwalton
added a commit
to pcwalton/webrender
that referenced
this pull request
Oct 6, 2015
out (rectangle subtraction) to the clipper. Known issues: * Clipping out does not clip the uv coordinates properly. * Clipping to rounded rectangle corners does not work yet. * Box shadows with elliptical radii are unsupported (also in master Servo). * Box shadows with heterogeneous radii for each corner are unsupported (also in master Servo). This PR depends on some changes to Servo to support the new border radius field in box shadow display items: servo/servo#7896
pcwalton
added a commit
to pcwalton/webrender
that referenced
this pull request
Oct 6, 2015
out (rectangle subtraction) to the clipper. Known issues: * Clipping out does not clip the uv coordinates properly. * Clipping to rounded rectangle corners does not work yet. * Box shadows with elliptical radii are unsupported (also in master Servo). * Box shadows with heterogeneous radii for each corner are unsupported (also in master Servo). This PR depends on some changes to Servo to support the new border radius field in box shadow display items: servo/servo#7896
bors-servo
pushed a commit
that referenced
this pull request
Oct 6, 2015
layout: Add a field in the display list for simple border radii on box shadows. Only supported in WebRender (with my upcoming PR) for now. r? @mbrubeck <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7896) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedOct 6, 2015
Only supported in WebRender (with my upcoming PR) for now.
r? @mbrubeck