form submission for <textarea> and <select>

[6112]

Fixes #7849.
Fixes #7850.

[jdm]

@nox, would you review this?

[nox]

Sure.

[nox]

Thanks for your contribution! See remarks on Reviewable.

-S-awaiting-review +S-needs-code-changes

---

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 5 unresolved discussions, all commit checks successful.

---

^{components/script/dom/htmlformelement.rs, line 255 [r1] (raw file):}
This is an anti-pattern, do this instead:

if let Some(datum) = input.get_form_datum(submitter) {
    data_set.push(datum);
}

---

^{components/script/dom/htmlformelement.rs, line 269 [r1] (raw file):}
There should be no space after the negation operator.

---

^{components/script/dom/htmlformelement.rs, line 272 [r1] (raw file):}
Reuse name here.

---

^{components/script/dom/htmlselectelement.rs, line 67 [r1] (raw file):}
Here you can instead do:

if let Some(option) = HTMLOptionElementCast::to_ref(&child) {
    ...
}

---

^{components/script/dom/htmlselectelement.rs, line 68 [r1] (raw file):}
Upcast the option to Node (let node = NodeCast::from_ref(option);) and use the method get_disabled_state() on that.

@jdm Does our IDL getter for the disabled attribute properly accounts for the disabled state in NodeFlags? It doesn't seem so. Should it?

---

Comments from the review on Reviewable.io

[jdm]

Mmm, I knew that Disabled thing sounded familiar: #4765 (comment)

[nox]

One last nitpick. Btw @6112, why are there no test expectations changes?

-S-awaiting-review +S-needs-code-changes

---

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

^{components/script/dom/htmlselectelement.rs, line 68 [r1] (raw file):}
Err, silly me, you can just do child.get_enabled_state() here.

---

Comments from the review on Reviewable.io

[6112]

As for the test expectations, I'm not quite sure what you mean. I'm very new here, and mostly clueless about the tests.

[jdm]

@nox I'm not sure how much automated testing exists for form submission right now; http://mxr.mozilla.org/servo/search?string=.submit doesn't reveal very many likely tests.

[eefriedman]

#7923 has a test for this.

[bors-servo]

☔ The latest upstream changes (presumably #7873) made this pull request unmergeable. Please resolve the merge conflicts.

[nox]

-S-awaiting-review

---

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from the review on Reviewable.io

[nox]

The file tests/wpt/metadata/html/semantics/forms/form-submission-0/url-encoded.html.ini should be completely removed given there are no remaining failing tests.

-S-awaiting-review +S-needs-code-changes

---

Reviewed 3 of 3 files at r6.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from the review on Reviewable.io

[bors-servo]

☔ The latest upstream changes (presumably #8955) made this pull request unmergeable. Please resolve the merge conflicts.

[KiChjang]

@6112 You're almost there! Is there anything that we can do to help?

[6112]

Thanks for reminding me, @KiChjang . I'd forgotten about this.

[nox]

@bors-servo r+

Perfect, thanks! Sorry didn't notice earlier that you had rebased.

---

Reviewed 3 of 3 files at r7.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from the review on Reviewable.io

[bors-servo]

📌 Commit 1f234af has been approved by nox

[bors-servo]

⌛ Testing commit 1f234af with merge 3d969e4...

[bors-servo]

💔 Test failed - mac-rel-wpt

[larsbergstrom]

@bors-servo retry

• #8769

[bors-servo]

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only linux-rel, mac-rel-wpt...

[bors-servo]

⛄ The build was interrupted to prioritize another pull request.

[bors-servo]

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only linux-rel, mac-rel-wpt...

[jdm]

@bors-servo: retry

• forced

[bors-servo]

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only linux-rel, mac-rel-wpt...

[bors-servo]

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt