Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for URL-encoded form submission. #7923

Merged
merged 1 commit into from Nov 22, 2015
Merged

Add test for URL-encoded form submission. #7923

merged 1 commit into from Nov 22, 2015

Conversation

@eefriedman
Copy link
Contributor

eefriedman commented Oct 8, 2015

This turned out to be a little more complicated than I was hoping...
but I can't really think of a better way to do this.

Review on Reviewable
@eefriedman eefriedman mentioned this pull request Oct 8, 2015
Merged
@jdm
Copy link
Member

jdm commented Oct 8, 2015

Why's the iframe loading a CSS file?
@eefriedman
Copy link
Contributor Author

eefriedman commented Oct 8, 2015

It doesn't really matter what the content is; it just needs to be some same-origin document which doesn't contain any scripts.
@eefriedman eefriedman force-pushed the eefriedman:url-encoded-test branch from 71435ee to b56d3ef Oct 8, 2015
@eefriedman
Copy link
Contributor Author

eefriedman commented Oct 8, 2015

Switched the iframe to an HTML file.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2015

☔ The latest upstream changes (presumably #7982) made this pull request unmergeable. Please resolve the merge conflicts.
@eefriedman eefriedman force-pushed the eefriedman:url-encoded-test branch from b56d3ef to 1fb49e2 Oct 13, 2015
@eefriedman
Copy link
Contributor Author

eefriedman commented Oct 13, 2015

Rebased.
@frewsxcv
Copy link
Member

frewsxcv commented Oct 13, 2015

Needs to be rebased again
@eefriedman eefriedman force-pushed the eefriedman:url-encoded-test branch from 1fb49e2 to 24334d1 Oct 13, 2015
@eefriedman
Copy link
Contributor Author

eefriedman commented Oct 13, 2015

Rebased again; sorry about the noise.
@eefriedman
Copy link
Contributor Author

eefriedman commented Nov 1, 2015

@Ms2ger Ping.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2015

☔ The latest upstream changes (presumably #8359) made this pull request unmergeable. Please resolve the merge conflicts.
@eefriedman eefriedman force-pushed the eefriedman:url-encoded-test branch from 24334d1 to a0298b6 Nov 13, 2015
@eefriedman
Copy link
Contributor Author

eefriedman commented Nov 13, 2015

Rebased again.

It's now been over one month since I submitted this PR.
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 16, 2015

r? @nox
@highfive highfive assigned nox and unassigned Ms2ger Nov 16, 2015
@jdm jdm removed the S-needs-rebase label Nov 16, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Nov 17, 2015

☔ The latest upstream changes (presumably #8561) made this pull request unmergeable. Please resolve the merge conflicts.
@nox
Copy link
Member

nox commented Nov 17, 2015

Looks good to me but it must be rebased.
@nox nox removed the S-awaiting-review label Nov 17, 2015
@eefriedman
Add test for URL-encoded form submission.
Loading status checks…
8c93046 
This turned out to be a little more complicated than I was hoping...
but I can't really think of a better way to do this.
@eefriedman eefriedman force-pushed the eefriedman:url-encoded-test branch from a0298b6 to 8c93046 Nov 21, 2015
@eefriedman
Copy link
Contributor Author

eefriedman commented Nov 21, 2015

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2015

📌 Commit 8c93046 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2015

⌛ Testing commit 8c93046 with merge d339d6d...
bors-servo added a commit that referenced this pull request Nov 21, 2015
@bors-servo
Auto merge of #7923 - eefriedman:url-encoded-test, r=nox
Loading status checks…
d339d6d 
Add test for URL-encoded form submission.

This turned out to be a little more complicated than I was hoping...
but I can't really think of a better way to do this.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7923)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 22, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 8c93046 into servo:master Nov 22, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@eefriedman @jdm @bors-servo @frewsxcv @Ms2ger @nox @highfive
You can’t perform that action at this time.