Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HTMLIFrameElement::pipeline_id on LayoutJS<HTMLIFrameElement>. #7925

Merged
merged 1 commit into from Oct 9, 2015
Merged

Implement HTMLIFrameElement::pipeline_id on LayoutJS<HTMLIFrameElement>. #7925

merged 1 commit into from Oct 9, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 8, 2015

Review on Reviewable
@Ms2ger
Implement HTMLIFrameElement::pipeline_id on LayoutJS<HTMLIFrameElement>.
Loading status checks…
25c19f7
@highfive
Copy link

highfive commented Oct 8, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Oct 8, 2015

r? @glennw
@glennw
Copy link
Member

glennw commented Oct 8, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 8, 2015

📌 Commit 25c19f7 has been approved by glennw
@bors-servo
Copy link
Contributor

bors-servo commented Oct 8, 2015

⌛ Testing commit 25c19f7 with merge 0895ca6...
bors-servo pushed a commit that referenced this pull request Oct 8, 2015
bors-servo
Auto merge of #7925 - Ms2ger:iframe-pipeline-layout, r=glennw
0895ca6 
Implement HTMLIFrameElement::pipeline_id on LayoutJS<HTMLIFrameElement>.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7925)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 8, 2015

💔 Test failed - linux-dev
@jdm
Copy link
Member

jdm commented Oct 9, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2015

⌛ Testing commit 25c19f7 with merge 14e349f...
bors-servo pushed a commit that referenced this pull request Oct 9, 2015
bors-servo
Auto merge of #7925 - Ms2ger:iframe-pipeline-layout, r=glennw
14e349f 
Implement HTMLIFrameElement::pipeline_id on LayoutJS<HTMLIFrameElement>.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7925)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2015

💔 Test failed - mac-rel-wpt
@jdm
Copy link
Member

jdm commented Oct 9, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2015

⌛ Testing commit 25c19f7 with merge 12139f7...
bors-servo pushed a commit that referenced this pull request Oct 9, 2015
bors-servo
Auto merge of #7925 - Ms2ger:iframe-pipeline-layout, r=glennw
Loading status checks…
12139f7 
Implement HTMLIFrameElement::pipeline_id on LayoutJS<HTMLIFrameElement>.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7925)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 25c19f7 into servo:master Oct 9, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@jdm jdm mentioned this pull request Oct 9, 2015
Merged
@Ms2ger Ms2ger deleted the Ms2ger:iframe-pipeline-layout branch Oct 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glennw glennw

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @glennw @bors-servo @jdm
You can’t perform that action at this time.