Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move event state from Node to Element #7935

Merged
merged 3 commits into from Oct 19, 2015
Merged

Move event state from Node to Element #7935

merged 3 commits into from Oct 19, 2015
+295 −307

Commits on Oct 17, 2015

  1. Move Event States to |Element|. 

    Conceptually they belong there, rather than on |Node|.

Fixes #7934.
    @bholley
    bholley committed Oct 17, 2015
    75ec093

  2. Move what is now an |impl Element| block to element.rs. 

    This is a simple cut/paste.
    @bholley
    bholley committed Oct 17, 2015
    ac8d57c

  3. Bump the expected sizes for Element. 

    After rebasing, this suddenly became a problem again, even though there's no actual size increase here
(we're shrinking NodeFlags by 1 byte, and adding 1 byte of EventState). Moving the NodeFlags to the end
of Node and the EventState bits to the beginning of Element doesn't seem to helper either.

This is probably a padding issue that's worth investigating at some point, but given the level
of churn in this code it doesn't seem worth it to fuss to much over this right now.
    @bholley
    bholley committed Oct 17, 2015
    Loading status checks…
    69255ed
You can’t perform that action at this time.