Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPrefer `.cloned()` over `.map(|foo| foo.clone())` #7946
Closed
Conversation
There are other combinations of map and clone in the code, but this commit only addresses the straightforward ones. Fixes 367.
|
As mentioned in the commit message, I ignored a number of "kinda similar instances".
Please, fail the review if you think some of these can and should also use .cloned() |
|
Your choices look reasonable to me! |
|
@bors-servo: r+ |
|
|
|
@bors-servo: r- |
|
thanks for bearing with me... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pierrechevalier83 commentedOct 9, 2015
There are other combinations of map and clone in the code, but
this commit only addresses the straightforward ones.
Fixes #7906.