Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed dom_class type to Option<&'static DOMClass> to fix #7942 #7948

Merged
merged 1 commit into from Oct 10, 2015
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -2357,11 +2357,11 @@ def definition_body(self):

if self.descriptor.concrete:
if self.descriptor.proxy:
domClass = "&Class"
domClass = "Some(&Class)"
else:
domClass = "&Class.dom_class"
domClass = "Some(&Class.dom_class)"
else:
domClass = "ptr::null()"
domClass = "None"

if self.descriptor.interface.hasInterfaceObject():
if self.descriptor.interface.ctor():
@@ -215,18 +215,23 @@ pub fn do_create_interface_objects(cx: *mut JSContext,
proto_class: Option<&'static JSClass>,
constructor: Option<(NonNullJSNative, &'static str, u32)>,
named_constructors: &[(NonNullJSNative, &'static str, u32)],
dom_class: *const DOMClass,
dom_class: Option<&'static DOMClass>,
members: &'static NativeProperties,
rval: MutableHandleObject) {
if let Some(proto_class) = proto_class {
create_interface_prototype_object(cx, proto_proto,
proto_class, members, rval);
}

unsafe {
if !rval.get().is_null() {
if !rval.get().is_null() {
let dom_class_ptr = match dom_class {
Some(dom_class) => dom_class as *const DOMClass as *const libc::c_void,
None => ptr::null() as *const libc::c_void,
};

unsafe {
JS_SetReservedSlot(rval.get(), DOM_PROTO_INSTANCE_CLASS_SLOT,
PrivateValue(dom_class as *const libc::c_void));
PrivateValue(dom_class_ptr));
}
}

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.