Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate magic number representing max unsigned long #7958

Merged
merged 1 commit into from Oct 10, 2015
Merged

Consolidate magic number representing max unsigned long #7958

merged 1 commit into from Oct 10, 2015
+15 −4

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Oct 10, 2015

Review on Reviewable
components/script/dom/values.rs
@@ -0,0 +1,3 @@
// https://html.spec.whatwg.org/multipage#reflecting-content-attributes-in-idl-attributes:idl-unsigned-long

This comment has been minimized.

Sign in to view
Copy link
@mbrubeck

mbrubeck Oct 10, 2015

Contributor

This file needs a license header. With that fixed, r=mbrubeck.
@mbrubeck mbrubeck self-assigned this Oct 10, 2015
@frewsxcv
Consolidate magic number representing max unsigned long
Loading status checks…
4dc8fd7
@frewsxcv frewsxcv force-pushed the frewsxcv:consolidate-magic-number branch from 68c294d to 4dc8fd7 Oct 10, 2015
@frewsxcv
Copy link
Member Author

frewsxcv commented Oct 10, 2015

@bors-servo r=mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2015

📌 Commit 4dc8fd7 has been approved by mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2015

⌛ Testing commit 4dc8fd7 with merge 02d8894...
bors-servo pushed a commit that referenced this pull request Oct 10, 2015
bors-servo
Auto merge of #7958 - frewsxcv:consolidate-magic-number, r=mbrubeck
Loading status checks…
02d8894 
Consolidate magic number representing max unsigned long



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7958)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2015

💔 Test failed - mac-rel-wpt
@jdm
Copy link
Member

jdm commented Oct 10, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2015

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 10, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 4dc8fd7 into servo:master Oct 10, 2015
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the frewsxcv:consolidate-magic-number branch Oct 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@frewsxcv @bors-servo @jdm @mbrubeck @SimonSapin @highfive
You can’t perform that action at this time.