Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ask_for_reset for HTMLSelectElement. #7963

Merged
merged 11 commits into from Oct 28, 2015
Merged

Implement ask_for_reset for HTMLSelectElement. #7963

merged 11 commits into from Oct 28, 2015
+184 −2

Commits on Oct 23, 2015

  1. Implement ask_for_reset for HTMLSelectElement. 

    Fixes #7774
    @dagnir
    dagnir committed Oct 23, 2015
    Loading status checks…
    b1d6b0f

  2. Implement pick_option.

    @dagnir
    dagnir committed Oct 23, 2015
    6e9e146

  3. Update and correct tests.

    @dagnir
    dagnir committed Oct 23, 2015
    c070c7a

  4. ask for reset and pick on option insert.

    @dagnir
    dagnir committed Oct 23, 2015
    Loading status checks…
    663801e

  5. Move cast into if block.

    @dagnir
    dagnir committed Oct 23, 2015
    ea21db6

Commits on Oct 24, 2015

  1. Update test. 

    Fix comments and test when size > 1.
    @dagnir
    dagnir committed Oct 24, 2015
    Loading status checks…
    fcfc391

Commits on Oct 25, 2015

  1. Replace if-else with match.

    @dagnir
    dagnir committed Oct 25, 2015
    b5e991c

  2. Remove extra indent.

    @dagnir
    dagnir committed Oct 25, 2015
    d561b4f

  3. Mark failure for remove test as expected. 

    Currently unable to get former parent after unbind_from_tree, so it's
not possible to call ask_for_reset upon removal.
    @dagnir
    dagnir committed Oct 25, 2015
    Loading status checks…
    15a8b6b

Commits on Oct 27, 2015

  1. Add fixes based on review. 

    - Whitespace and indentation issues

- call as_for_reset on option insert

- add link to 'pick' in standard
    @dagnir
    dagnir committed Oct 27, 2015
    Loading status checks…
    92e0083

Commits on Oct 28, 2015

  1. Add fixes based on review. 

    - Use if let instead of match for Option

- Refactor common code into pick_if_selected_and_reset
    @dagnir
    dagnir committed Oct 28, 2015
    Loading status checks…
    4849033
You can’t perform that action at this time.