Implement HTMLHyperlinkElementUtils for HTMLAnchorElement

[jdramani]

Fixes #7857

[jdm]

r? @nox

[nox]

-S-awaiting-review +S-needs-code-changes

You use a get_url() method on HTMLAnchorElement but it's not defined anywhere.

---

Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks pending.

---

Comments from the review on Reviewable.io

[jdramani]

Should I include url : Url in HTMLAnchorElement structure and use it as UrlHelper::Host(&self.url) ?

[nox]

@jdm As I said earlier, the URL specification is quite changing these days, URLUtils is gone etc.

@jdramani You should do what is needed to follow the spec, an HTMLAnchorElement may not have an URL at all.

[nox]

This should wait for #8008 to land.

[nox]

#8008 landed.

[bors-servo]

☔ The latest upstream changes (presumably #8089) made this pull request unmergeable. Please resolve the merge conflicts.

[jdramani]

Now because of the following change in HTMLAnchorElement.webidl

-//HTMLAnchorElement implements URLUtils;
+//HTMLAnchorElement implements HTMLHyperlinkElementUtils;

We should implement HTMLHyperlinkElementUtils for HTMLAnchorEement , right?

[nox]

@jdramani Yes!

[nox]

@jdramani Ping?

[jdramani]

I am sry. I am stuck in my work but i would like to do it in the next week if there is no urgency.

[jdm]

That's fine!

[frewsxcv]

The spec changed for URLUtils: whatwg/html#219

[nox]

@jdramani Ping?

[frewsxcv]

components/script/dom/htmlanchorelement.rs, line 29 [r2] (raw file):
This import should be on the line above this so it appears before UrlParser (for alphabetic reasons)

---

Comments from the review on Reviewable.io

[frewsxcv]

components/script/dom/htmlanchorelement.rs, line 114 [r2] (raw file):
Where did the spec links go for all these methods?

---

Comments from the review on Reviewable.io

[frewsxcv]

components/script/dom/webidls/HTMLHyperlinkElementUtils.webidl, line 9 [r2] (raw file):
Comment out this line and add attribute USVString href; on the following line. We don't support stringifier attribute yet #7590

---

Comments from the review on Reviewable.io

[jdramani]

should I provide this link https://html.spec.whatwg.org/multipage/semantics.html#api-for-a-and-area-elements ?

[frewsxcv]

Use the same links found here: https://github.com/servo/servo/blob/master/components/script/dom/url.rs#L90-L203

[frewsxcv]

This currently doesn't compile: https://travis-ci.org/servo/servo/jobs/96659745

[frewsxcv]

I think you need to uncomment this line partially so it becomes:

[NoInterfaceObject/*, Exposed=Window*/]

Because right now, it's looking in components/script/dom/htmlhyperlinkelementutils.rs for a concrete DOM structure, which shouldn't exist since this interface is marked as NoInterfaceObject

[frewsxcv]

Use the same links found here: https://github.com/servo/servo/blob/master/components/script/dom/url.rs#L90-L203

Blah, I'm sorry, I was wrong in this comment. You're going to want to link to the items found here.

For example, for the Protocol method, link to this

[frewsxcv]

This should be https://html.spec.whatwg.org/multipage/#dom-hyperlink-hash

You should run ./mach test-tidy to see the errors that are occurring

[KiChjang]

@jdramani do you need help finishing this PR?

[jdramani]

Let me give it a final try and then i will let you know. Sry for the delay.

On Mon, Dec 28, 2015 at 7:08 PM, Keith Yeung notifications@github.com
wrote:

@jdramani https://github.com/jdramani do you need help finishing this
PR?

—
Reply to this email directly or view it on GitHub
#7964 (comment).

[Ms2ger]

Thanks for your work! I tried to finish it, but didn't quite get everything done. PR at #9292.