Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIMEClassifier::classify always succeeds; fix the type to reflect this. #7967

Merged
merged 1 commit into from Oct 14, 2015

Conversation

@eefriedman
Copy link
Contributor

eefriedman commented Oct 11, 2015

Review on Reviewable

@jdm jdm self-assigned this Oct 13, 2015
@jdm
Copy link
Member

jdm commented Oct 13, 2015

-S-awaiting-review +S-awaiting-answer


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


components/net/mime_classifier.rs, line 45 [r1] (raw file):
Why this change?


Comments from the review on Reviewable.io

@eefriedman
Copy link
Contributor Author

eefriedman commented Oct 13, 2015

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


components/net/mime_classifier.rs, line 45 [r1] (raw file):
A few lines later, the function calls supplied_type.clone()... that needs to result in (String, String), not Option<(String, String)>.


Comments from the review on Reviewable.io

@jdm
Copy link
Member

jdm commented Oct 13, 2015

@bors-servo: r+
-S-awaiting-answer


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from the review on Reviewable.io

@jdm jdm removed the S-awaiting-answer label Oct 13, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Oct 13, 2015

📌 Commit a4870aa has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2015

Testing commit a4870aa with merge 4cc42c4...

bors-servo pushed a commit that referenced this pull request Oct 14, 2015
MIMEClassifier::classify always succeeds; fix the type to reflect this.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7967)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2015

💔 Test failed - linux-dev

@eefriedman eefriedman force-pushed the eefriedman:mime-handling branch from a4870aa to 1c49622 Oct 14, 2015
@eefriedman
Copy link
Contributor Author

eefriedman commented Oct 14, 2015

Fixed unit-test.

@jdm
Copy link
Member

jdm commented Oct 14, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2015

📌 Commit 1c49622 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2015

Testing commit 1c49622 with merge 7308d0d...

bors-servo pushed a commit that referenced this pull request Oct 14, 2015
MIMEClassifier::classify always succeeds; fix the type to reflect this.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7967)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2015

💔 Test failed - linux-rel

@jdm
Copy link
Member

jdm commented Oct 14, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2015

Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-wpt are reusable. Rebuilding only linux-rel, mac-rel-css...

@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2015

@bors-servo bors-servo merged commit 1c49622 into servo:master Oct 14, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.