Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMIMEClassifier::classify always succeeds; fix the type to reflect this. #7967
Conversation
|
-S-awaiting-review +S-awaiting-answer Reviewed 2 of 2 files at r1. components/net/mime_classifier.rs, line 45 [r1] (raw file): Comments from the review on Reviewable.io |
|
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful. components/net/mime_classifier.rs, line 45 [r1] (raw file): Comments from the review on Reviewable.io |
|
@bors-servo: r+ Review status: Comments from the review on Reviewable.io |
|
|
MIMEClassifier::classify always succeeds; fix the type to reflect this. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7967) <!-- Reviewable:end -->
|
|
|
Fixed unit-test. |
|
@bors-servo: r+ |
|
|
MIMEClassifier::classify always succeeds; fix the type to reflect this. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7967) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
|
|
|
|
eefriedman commentedOct 11, 2015