Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIntroduce DOMClass::heap_size_of #7972
Conversation
highfive
commented
Oct 11, 2015
|
-S-awaiting-review +S-needs-code-changes Reviewed 4 of 4 files at r1. components/script/dom/bindings/codegen/CodegenRust.py, line 1752 [r1] (raw file): components/script/mem.rs, line 16 [r1] (raw file): components/script/mem.rs, line 23 [r1] (raw file): components/script/mem.rs, line 28 [r1] (raw file): Comments from the review on Reviewable.io |
|
|
|
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. components/script/mem.rs, line 16 [r1] (raw file): Comments from the review on Reviewable.io |
|
|
It holds a function pointer to the HeapSizeOf::heap_size_of_children() implementation corresponding to that IDL interface. This removes the need for a clumsly TypeId-based match expression in the former heap_size_of_eventtarget() function.
|
-S-awaiting-review +S-awaiting-merge Reviewed 3 of 3 files at r2. components/script/mem.rs, line 16 [r1] (raw file): Comments from the review on Reviewable.io |
|
|
|
|
Introduce DOMClass::heap_size_of It holds a function pointer to the HeapSizeOf::heap_size_of_children() implementation corresponding to that IDL interface. This removes the need for a clumsly TypeId-based match expression in the former heap_size_of_eventtarget() function. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7972) <!-- Reviewable:end -->
|
|
nox commentedOct 11, 2015
It holds a function pointer to the HeapSizeOf::heap_size_of_children()
implementation corresponding to that IDL interface.
This removes the need for a clumsly TypeId-based match expression in the
former heap_size_of_eventtarget() function.