Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor resource loaders to use send_error utility. #7984

Merged
merged 1 commit into from Oct 14, 2015
Merged

Refactor resource loaders to use send_error utility. #7984

merged 1 commit into from Oct 14, 2015
+20 −26

Conversation

@eefriedman
Copy link
Contributor

eefriedman commented Oct 12, 2015

No substantial functional change.

Review on Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Oct 13, 2015

☔ The latest upstream changes (presumably #7990) made this pull request unmergeable. Please resolve the merge conflicts.
@jdm jdm self-assigned this Oct 13, 2015
@jdm
Copy link
Member

jdm commented Oct 13, 2015

This is ready to merge after a rebase. Thanks!
-S-awaiting-review

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from the review on Reviewable.io
@jdm jdm removed the S-awaiting-review label Oct 13, 2015
@eefriedman
Refactor resource loaders to use send_error utility.
Loading status checks…
10664cf 
No substantial functional change.
@eefriedman eefriedman force-pushed the eefriedman:net-send-error branch from 7cdbcae to 10664cf Oct 13, 2015
@eefriedman
Copy link
Contributor Author

eefriedman commented Oct 13, 2015

Rebased.
@jdm
Copy link
Member

jdm commented Oct 13, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 13, 2015

📌 Commit 10664cf has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2015

⌛ Testing commit 10664cf with merge 8b1620e...
bors-servo pushed a commit that referenced this pull request Oct 14, 2015
bors-servo
Auto merge of #7984 - eefriedman:net-send-error, r=jdm
8b1620e 
Refactor resource loaders to use send_error utility.

No substantial functional change.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7984)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2015

💔 Test failed - mac-dev-ref-unit
@jdm
Copy link
Member

jdm commented Oct 14, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2015

⌛ Testing commit 10664cf with merge 8ca9540...
bors-servo pushed a commit that referenced this pull request Oct 14, 2015
bors-servo
Auto merge of #7984 - eefriedman:net-send-error, r=jdm
8ca9540 
Refactor resource loaders to use send_error utility.

No substantial functional change.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7984)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2015

💔 Test failed - mac-dev-ref-unit
@jdm
Copy link
Member

jdm commented Oct 14, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2015

⌛ Testing commit 10664cf with merge f35f809...
bors-servo pushed a commit that referenced this pull request Oct 14, 2015
bors-servo
Auto merge of #7984 - eefriedman:net-send-error, r=jdm
Loading status checks…
f35f809 
Refactor resource loaders to use send_error utility.

No substantial functional change.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7984)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2015

💔 Test failed - mac-rel-wpt
@jdm
Copy link
Member

jdm commented Oct 14, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2015

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
This was referenced Oct 14, 2015
Merged
Merged
Merged
Closed
@bors-servo bors-servo merged commit 10664cf into servo:master Oct 14, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@eefriedman @bors-servo @jdm @SimonSapin @highfive
You can’t perform that action at this time.