Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove webdriver use of SubpageId #8009

Merged
merged 1 commit into from Oct 15, 2015
Merged

Remove webdriver use of SubpageId #8009

merged 1 commit into from Oct 15, 2015

Conversation

@glennw
Copy link
Member

glennw commented Oct 14, 2015

Review on Reviewable
@glennw
Copy link
Member Author

glennw commented Oct 14, 2015

r? @jgraham or @jdm
@jdm
Copy link
Member

jdm commented Oct 14, 2015

-S-awaiting-review +S-needs-code-changes

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

components/script/webdriver_handlers.rs, line 111 [r1] (raw file):
let frame_id = window.map(|x| x.map(|x| x.r().pipeline()));

Comments from the review on Reviewable.io
@jdm jdm assigned jdm and unassigned jgraham Oct 14, 2015
@gw3583
Remove webdriver use of SubpageId
Loading status checks…
ed72e57
@glennw glennw force-pushed the glennw:webdriver-subpage branch from cb9de87 to ed72e57 Oct 14, 2015
@glennw
Copy link
Member Author

glennw commented Oct 14, 2015

Review status: 4 of 5 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.

components/script/webdriver_handlers.rs, line 111 [r1] (raw file):
Done.

Comments from the review on Reviewable.io
@jdm
Copy link
Member

jdm commented Oct 14, 2015

@bors-servo: r+

Reviewed 1 of 1 files at r2.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2015

📌 Commit ed72e57 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2015

⌛ Testing commit ed72e57 with merge bcf3260...
bors-servo pushed a commit that referenced this pull request Oct 14, 2015
bors-servo
Auto merge of #8009 - glennw:webdriver-subpage, r=jdm
bcf3260 
Remove webdriver use of SubpageId



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8009)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 14, 2015

💔 Test failed - mac-dev-ref-unit
@jdm
Copy link
Member

jdm commented Oct 14, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2015

⌛ Testing commit ed72e57 with merge ac73374...
bors-servo pushed a commit that referenced this pull request Oct 15, 2015
bors-servo
Auto merge of #8009 - glennw:webdriver-subpage, r=jdm
Loading status checks…
ac73374 
Remove webdriver use of SubpageId



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8009)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit ed72e57 into servo:master Oct 15, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@glennw glennw deleted the glennw:webdriver-subpage branch Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@glennw @jdm @bors-servo @jgraham @highfive @gw3583
You can’t perform that action at this time.