Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wptrunner for some old-style reftests. #8010

Merged
merged 18 commits into from Oct 15, 2015
Merged

Use wptrunner for some old-style reftests. #8010

merged 18 commits into from Oct 15, 2015

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Oct 14, 2015

Part of #5618

Review on Reviewable
@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 14, 2015

+S-needs-code-changes -S-awaiting-review

Reviewed 6 of 6 files at r1, 5 of 5 files at r2, 6 of 6 files at r3, 6 of 6 files at r4, 6 of 6 files at r5, 6 of 6 files at r6, 6 of 6 files at r7, 6 of 6 files at r8, 6 of 6 files at r9, 6 of 6 files at r10, 6 of 6 files at r11, 6 of 6 files at r12, 6 of 6 files at r13, 6 of 6 files at r14, 6 of 6 files at r15, 6 of 6 files at r16, 6 of 6 files at r17, 6 of 6 files at r18, 6 of 6 files at r19.
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

tests/wpt/mozilla/meta/MANIFEST.json, line 500 [r3] (raw file):
This change ended up in the wrong commit.

tests/wpt/mozilla/tests/css/viewport_rule_ref.html, line 1 [r2] (raw file):
This file needs to stay here for viewport_rule.html.

Comments from the review on Reviewable.io
@frewsxcv frewsxcv force-pushed the frewsxcv:migrate-test-ref branch from d95eebb to 3e5acfb Oct 14, 2015
@frewsxcv frewsxcv force-pushed the frewsxcv:migrate-test-ref branch 2 times, most recently from 9e5b16b to e89b92d Oct 14, 2015
@frewsxcv
Copy link
Member Author

frewsxcv commented Oct 14, 2015

Let me know how that looks
@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 15, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2015

📌 Commit e89b92d has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2015

⌛ Testing commit e89b92d with merge 1246c7c...
bors-servo pushed a commit that referenced this pull request Oct 15, 2015
bors-servo
Auto merge of #8010 - frewsxcv:migrate-test-ref, r=Ms2ger
1246c7c 
Use wptrunner for some old-style reftests.

Part of #5618

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8010)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2015

💔 Test failed - linux-dev
frewsxcv added 10 commits Oct 14, 2015
@frewsxcv
Move vertical_align_top_span_a.html to wpt reftests.
77d5f85
@frewsxcv
Move visibility_hidden.html to wpt reftests.
ff57bd5
@frewsxcv
Move vertical_align_top_bottom_a.html to wpt reftests.
18590c5
@frewsxcv
Move vertical_align_top_a.html to wpt reftests.
c71d9cd
@frewsxcv
Move vertical_align_text_top_a.html to wpt reftests.
a3d799e
@frewsxcv
Move upper_id_attr.html to wpt reftests.
089fc93
@frewsxcv
Move transition_calc.html to wpt reftests.
5724411
@frewsxcv
Move transform_stacking_context_a.html to wpt reftests.
60000ea
@frewsxcv
Move transform_skew_a.html to wpt reftests.
0ae55ed
@frewsxcv
Move transform_simple_a.html to wpt reftests.
be594f6
frewsxcv added 8 commits Oct 14, 2015
@frewsxcv
Move vertical_align_text_bottom_a.html to wpt reftests.
c3e8d5d
@frewsxcv
Move vertical_align_super_nested_a.html to wpt reftests.
18ae331
@frewsxcv
Move vertical_align_super_a.html to wpt reftests.
bca2106
@frewsxcv
Move vertical_align_sub_a.html to wpt reftests.
3c44bee
@frewsxcv
Move vertical_align_inside_table_a.html to wpt reftests.
dbbfde7
@frewsxcv
Move vertical_align_inline_block_a.html to wpt reftests.
ac76350
@frewsxcv
Move vertical_align_bottom_a.html to wpt reftests.
9216468
@frewsxcv
Move transform_optimization.html to wpt reftests.
Loading status checks…
5df2375
@frewsxcv frewsxcv force-pushed the frewsxcv:migrate-test-ref branch from e89b92d to 5df2375 Oct 15, 2015
@frewsxcv
Copy link
Member Author

frewsxcv commented Oct 15, 2015

I accidentally deleted a couple files. I added them back in.
@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 15, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2015

📌 Commit 5df2375 has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2015

⌛ Testing commit 5df2375 with merge 6f1db0f...
bors-servo pushed a commit that referenced this pull request Oct 15, 2015
bors-servo
Auto merge of #8010 - frewsxcv:migrate-test-ref, r=Ms2ger
Loading status checks…
6f1db0f 
Use wptrunner for some old-style reftests.

Part of #5618

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8010)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 5df2375 into servo:master Oct 15, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the frewsxcv:migrate-test-ref branch Oct 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@frewsxcv @Ms2ger @bors-servo @highfive
You can’t perform that action at this time.