Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate all Derived implementations in codegen #8020

Merged
merged 2 commits into from Oct 15, 2015

Conversation

@nox
Copy link
Member

nox commented Oct 14, 2015

Follow-up of #7873.

@Ms2ger r? :)

Review on Reviewable

@nox
Copy link
Member Author

nox commented Oct 15, 2015

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 15, 2015

-S-awaiting-review +S-needs-code-changes


Reviewed 93 of 93 files at r1, 78 of 78 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.


components/script/dom/element.rs, line 122 [r2] (raw file):
This would probably need allow(unrooted_must_root) if that lint worked.


components/script/dom/htmlelement.rs, line 55 [r2] (raw file):
Or whitelist it in unrooted_must_root.rs if there's a lot of those.


Comments from the review on Reviewable.io

Given codegen now generates the various TypeId enums, it seems pointless to
still have to write their respective values in every DOM struct inheriting from
Node just to set the initial IS_IN_DOC flag in Document and IN_ENABLED_STATE in
form controls.
@nox nox force-pushed the nox:codegen-derived branch from f21c392 to 7d6ea83 Oct 15, 2015
@nox
Copy link
Member Author

nox commented Oct 15, 2015

@Ms2ger Whitelisted all new_* functions.

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 15, 2015

-S-awaiting-review +S-awaiting-merge
@bors-servo r+


Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks pending.


Comments from the review on Reviewable.io

@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2015

📌 Commit 7d6ea83 has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2015

Testing commit 7d6ea83 with merge 417cf57...

bors-servo pushed a commit that referenced this pull request Oct 15, 2015
Generate all Derived implementations in codegen

Follow-up of #7873.

@Ms2ger r? :)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8020)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2015

@bors-servo bors-servo merged commit 7d6ea83 into servo:master Oct 15, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the nox:codegen-derived branch Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.