Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGenerate all Derived implementations in codegen #8020
Conversation
|
@bors-servo p=1 |
|
-S-awaiting-review +S-needs-code-changes Reviewed 93 of 93 files at r1, 78 of 78 files at r2. components/script/dom/element.rs, line 122 [r2] (raw file): components/script/dom/htmlelement.rs, line 55 [r2] (raw file): Comments from the review on Reviewable.io |
Given codegen now generates the various TypeId enums, it seems pointless to still have to write their respective values in every DOM struct inheriting from Node just to set the initial IS_IN_DOC flag in Document and IN_ENABLED_STATE in form controls.
|
@Ms2ger Whitelisted all new_* functions. |
|
-S-awaiting-review +S-awaiting-merge Reviewed 1 of 1 files at r3. Comments from the review on Reviewable.io |
|
|
Generate all Derived implementations in codegen Follow-up of #7873. @Ms2ger r? :) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8020) <!-- Reviewable:end -->
|
|
nox commentedOct 14, 2015
Follow-up of #7873.
@Ms2ger r? :)