Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upgenerate JIT argument type information for methods #8040
Conversation
|
In case you missed it there are merge conflicts. |
|
Maybe |
|
r? @jdm |
|
-S-awaiting-review +S-needs-code-changes Reviewed 1 of 1 files at r1, 1 of 1 files at r2. components/script/dom/bindings/codegen/CodegenRust.py, line 3097 [r2] (raw file): components/script/dom/bindings/codegen/CodegenRust.py, line 3104 [r2] (raw file): Comments from the review on Reviewable.io |
|
@bors-servo: r+ Reviewed 1 of 1 files at r3. Comments from the review on Reviewable.io |
|
|
generate JIT argument type information for methods This enhances `CodegenRust.py` to output `JSTypedMethodJitInfo` structures where appropriate. This brings a notable speedup to tests like Dromaeo's `dom-attr/getAttribute`, which improves by several orders of magnitude with these patches applied. If there are tricks for addressing the XXX comments, I would appreciate hearing them. I think this addresses all of #6904. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8040) <!-- Reviewable:end -->
|
|
froydnj commentedOct 15, 2015
This enhances
CodegenRust.pyto outputJSTypedMethodJitInfostructures where appropriate. This brings a notable speedup to tests like Dromaeo'sdom-attr/getAttribute, which improves by several orders of magnitude with these patches applied.If there are tricks for addressing the XXX comments, I would appreciate hearing them.
I think this addresses all of #6904.