Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AsyncResponseListener methods take `&mut self` #8043

Merged
merged 2 commits into from Oct 16, 2015

Conversation

@eefriedman
Copy link
Contributor

eefriedman commented Oct 15, 2015

Gets rid of a bunch of useless Cell/RefCell types.

Review on Reviewable

@jdm
Copy link
Member

jdm commented Oct 16, 2015

@bors-servo: r+
This is a great improvement; thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2015

📌 Commit 827f2b8 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2015

Testing commit 827f2b8 with merge a4f9c2f...

bors-servo pushed a commit that referenced this pull request Oct 16, 2015
Make AsyncResponseListener methods take `&mut self`

Gets rid of a bunch of useless `Cell`/`RefCell` types.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8043)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2015

💔 Test failed - mac-rel-css

@jdm
Copy link
Member

jdm commented Oct 16, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2015

Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-wpt are reusable. Rebuilding only linux-rel, mac-rel-css...

@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2015

💔 Test failed - linux-rel

@jdm
Copy link
Member

jdm commented Oct 16, 2015

This is #7870 and #7625 (which will cause any retries to fail until we solve the font issue again).

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 16, 2015

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2015

Testing commit 827f2b8 with merge 76db849...

bors-servo pushed a commit that referenced this pull request Oct 16, 2015
Make AsyncResponseListener methods take `&mut self`

Gets rid of a bunch of useless `Cell`/`RefCell` types.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8043)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2015

💔 Test failed - linux-rel

@nox
Copy link
Member

nox commented Oct 16, 2015

@nox nox assigned jdm Oct 16, 2015
@nox nox added the I-refactor label Oct 16, 2015
@nox nox added S-awaiting-merge and removed S-tests-failed labels Oct 16, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2015

Testing commit 827f2b8 with merge 724d4e1...

bors-servo pushed a commit that referenced this pull request Oct 16, 2015
Make AsyncResponseListener methods take `&mut self`

Gets rid of a bunch of useless `Cell`/`RefCell` types.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8043)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2015

@bors-servo bors-servo merged commit 827f2b8 into servo:master Oct 16, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.