Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Deref<Target=T> for JS<T> where T: Reflectable #8060

Merged
merged 21 commits into from Oct 19, 2015
Merged

Implement Deref<Target=T> for JS<T> where T: Reflectable #8060

merged 21 commits into from Oct 19, 2015
+187 −274

Commits on Oct 16, 2015

  1. Implement Deref<Target=T> for JS<T> where T: Reflectable 

    We can only borrow JS<T> from rooted things, so it's safe to deref it.
The only types that provide mutable JS<T> things are MutHeap<JS<T>> and
MutNullableHeap<JS<T>>, which don't actually expose that they contain
JS<T> values.
    @nox
    nox committed Oct 16, 2015
    6c7f370

Commits on Oct 17, 2015

  1. Return a reference in BrowserContext::active_document()

    @nox
    nox committed Oct 17, 2015
    1f31d5b

  2. Return a reference in BrowserContext::frame_element()

    @nox
    nox committed Oct 17, 2015
    264e943

Commits on Oct 19, 2015

  1. Do not root Document::window

    @nox
    nox committed Oct 19, 2015
    e889b09

  2. Return a reference in Document::window()

    @nox
    nox committed Oct 19, 2015
    409b5e3

  3. Return a reference in BrowserContext::active_window()

    @nox
    nox committed Oct 19, 2015
    6ab7f64

  4. Do not root DOMImplementation::document

    @nox
    nox committed Oct 19, 2015
    ce6aab6

  5. Do not root DOMParser::window

    @nox
    nox committed Oct 19, 2015
    ff0da2f

  6. Do not root DOMStringMap::element

    @nox
    nox committed Oct 19, 2015
    822e6f0

  7. Do not root DOMTokenList::element

    @nox
    nox committed Oct 19, 2015
    71dcabf

  8. Do not root InputActivationState::checked_radio

    @nox
    nox committed Oct 19, 2015
    e8f358d

  9. Do not root HTMLScriptElement::parser_document

    @nox
    nox committed Oct 19, 2015
    dee3aec

  10. Do not root Location::window

    @nox
    nox committed Oct 19, 2015
    5889a75

  11. Do not root NamedNodeMap::owner

    @nox
    nox committed Oct 19, 2015
    6849510

  12. Do not root NodeIterator::root_node

    @nox
    nox committed Oct 19, 2015
    b149e0c

  13. Do not root ChildrenList::node

    @nox
    nox committed Oct 19, 2015
    17cd420

  14. Do not root Performance::timing

    @nox
    nox committed Oct 19, 2015
    b0d1ccd

  15. Do not root Sink::document

    @nox
    nox committed Oct 19, 2015
    7c47a6b

  16. Do not root ServoHTMLParser::document

    @nox
    nox committed Oct 19, 2015
    da06341

  17. Return a reference in ServoHTMLParser::window()

    @nox
    nox committed Oct 19, 2015
    d28de59

  18. Do not root XMLHttpRequest::upload

    @nox
    nox committed Oct 19, 2015
    Loading status checks…
    6dc42dd
You can’t perform that action at this time.