Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removced unncessary call to dirty() in Document::node_and_heritage_ch… #8087

Merged
merged 1 commit into from Nov 3, 2015
Merged

Removced unncessary call to dirty() in Document::node_and_heritage_ch… #8087

merged 1 commit into from Nov 3, 2015
+0 −1

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Oct 19, 2015

Removed unncessary call to dirty() in Document::node_and_heritage_change, since the node is aready dirtied by force_dirty_ancestors().

Review on Reviewable
@highfive
Copy link

highfive commented Oct 19, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.
@frewsxcv
Copy link
Member

frewsxcv commented Oct 19, 2015

Congrats on your first Servo pull request! 🎊

On a side note, it might be worth looking into associating your git commits with your GitHub username. Here's a document on the topic: https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user
@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 20, 2015

r? @pcwalton
@asajeffrey
Copy link
Member Author

asajeffrey commented Oct 20, 2015

I updated my email on github to be my Mozilla account. Hopefully my commits will not now be anonymous.
@nox nox added the S-needs-rebase label Oct 21, 2015
@nox
Copy link
Member

nox commented Oct 21, 2015

@asajeffrey There are merge commits that shouldn't be here.
@asajeffrey asajeffrey force-pushed the asajeffrey:dont_dirty_twice branch from f96a84d to a1dcbc9 Oct 22, 2015
@pcwalton
Copy link
Contributor

pcwalton commented Nov 2, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2015

📌 Commit a1dcbc9 has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2015

⌛ Testing commit a1dcbc9 with merge d94a38b...
bors-servo added a commit that referenced this pull request Nov 2, 2015
@bors-servo
Auto merge of #8087 - asajeffrey:dont_dirty_twice, r=pcwalton
d94a38b 
Removced unncessary call to dirty() in Document::node_and_heritage_ch…

Removed unncessary call to dirty() in Document::node_and_heritage_change, since the node is aready dirtied by force_dirty_ancestors().

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8087)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2015

💔 Test failed - linux-rel
@eefriedman
Copy link
Contributor

eefriedman commented Nov 2, 2015

@bors-servo retry [buildbot issue]
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2015

⌛ Testing commit a1dcbc9 with merge 757f4eb...
bors-servo added a commit that referenced this pull request Nov 3, 2015
@bors-servo
Auto merge of #8087 - asajeffrey:dont_dirty_twice, r=pcwalton
757f4eb 
Removced unncessary call to dirty() in Document::node_and_heritage_ch…

Removed unncessary call to dirty() in Document::node_and_heritage_change, since the node is aready dirtied by force_dirty_ancestors().

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8087)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2015

💔 Test failed - mac-rel-wpt
@eefriedman
Copy link
Contributor

eefriedman commented Nov 3, 2015

@bors-servo retry #8191
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2015

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css are reusable. Rebuilding only linux-rel, mac-rel-wpt...
@Ms2ger Ms2ger closed this Nov 3, 2015
@frewsxcv frewsxcv reopened this Nov 3, 2015
@frewsxcv
Copy link
Member

frewsxcv commented Nov 3, 2015 


```
command interrupted, attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=1183.929747
```

EDIT: @Ms2ger was responsible for this interrupt
@asajeffrey
Removced unncessary call to dirty() in Document::node_and_heritage_ch…
Loading status checks…
d3ea0a0 
…ange, since the node is aready dirtied by force_dirty_ancestors().
@asajeffrey asajeffrey force-pushed the asajeffrey:dont_dirty_twice branch from a1dcbc9 to d3ea0a0 Nov 3, 2015
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 3, 2015

@bors-servo r=pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2015

📌 Commit d3ea0a0 has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2015

⌛ Testing commit d3ea0a0 with merge 23efa0a...
bors-servo added a commit that referenced this pull request Nov 3, 2015
@bors-servo
Auto merge of #8087 - asajeffrey:dont_dirty_twice, r=pcwalton
Loading status checks…
23efa0a 
Removced unncessary call to dirty() in Document::node_and_heritage_ch…

Removed unncessary call to dirty() in Document::node_and_heritage_change, since the node is aready dirtied by force_dirty_ancestors().

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8087)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 3, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit d3ea0a0 into servo:master Nov 3, 2015
2 of 3 checks passed
2 of 3 checks passed
code-review/reviewable Review in progress: 0 of 1 files reviewed, all discussions resolved
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@asajeffrey @highfive @frewsxcv @Ms2ger @nox @pcwalton @bors-servo @eefriedman
You can’t perform that action at this time.