Remove Rc<T> usage from Range

[nox]

I initially used this to correctly handle ranges when their respective containers
are mutated, to get weak references of Range objects. I now realise that the weak
references should be handled at a lower level, closer to the JS-managed object.

[bors-servo]

☔ The latest upstream changes (presumably #8041) made this pull request unmergeable. Please resolve the merge conflicts.

[eefriedman]

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

^{components/script/dom/range.rs, line 123 [r1] (raw file):}
Are you sure self.start > self.end is correct, as opposed to !(self.start <= self.end)? (I would hope that the WPT tests cover this... but please add a test if they don't.)

---

Comments from the review on Reviewable.io

[jdm]

@eefriedman is reviewing this PR.

[nox]

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

^{components/script/dom/range.rs, line 123 [r1] (raw file):}
Why would one be correct and not the other? I'm not sure I understand.

---

Comments from the review on Reviewable.io

[eefriedman]

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

^{components/script/dom/range.rs, line 123 [r1] (raw file):}
self.start > self.end is equivalent to self.start.partial_cmp(self.end) == Some(Ordering::Greater). The original code checks for None | Some(Ordering::Greater). The difference is relevant if the two nodes aren't part of the same tree.

---

Comments from the review on Reviewable.io

[nox]

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

^{components/script/dom/range.rs, line 123 [r1] (raw file):}
Oh, good catch. I'll check that the tests fail and will fix the code accordingly.

---

Comments from the review on Reviewable.io

[nox]

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.

---

^{components/script/dom/range.rs, line 123 [r1] (raw file):}
Half the tests in /dom/ranges/Range-set.html were failing without this change, indeed.

---

Comments from the review on Reviewable.io

[eefriedman]

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.

---

^{components/script/dom/range.rs, line 124 [r3] (raw file):}
The comment is confusing. If you think the algorithm needs to be described, say a bit more, like "if the current end is before the start or in another document, set the end to the same point as the start". If you think !(a<=b) needs to be clarified, just change it to call bp_position or partial_cmp directly.

---

Comments from the review on Reviewable.io

[nox]

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.

---

^{components/script/dom/range.rs, line 124 [r3] (raw file):}
I removed the comment, I already spent too much time on this patch. :)

---

Comments from the review on Reviewable.io

[eefriedman]

OK.

r=me.

[nox]

@bors-servo r=eefriedman

Thanks for the review!

[bors-servo]

📌 Commit a1b15d3 has been approved by eefriedman

[bors-servo]

⌛ Testing commit a1b15d3 with merge e3bcf7b...

[bors-servo]

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt